Giter Site home page Giter Site logo

Comments (5)

vlucas avatar vlucas commented on May 2, 2024

I agree that this should be able to be escaped. I will definitely accept a PR to the v2 branch. I am about to do a v2.0.0 release, so get it in fast! ;)

from phpdotenv.

xjchengo avatar xjchengo commented on May 2, 2024

ok, i will send a PR today.

from phpdotenv.

xjchengo avatar xjchengo commented on May 2, 2024

I have send a PR. With regard to nested variables, I have following thoughts:

  • remove nested variable support in JSON format

    JSON standard doesn't support nested variable. JSON is used primarily to transmit data between a server and web application. If I use a nested variable in JSON, I cannot use it in other place. For example, I cannot directly use a json config with nested variable in a project without phpdotenv package. And the nested variables in json file is a little confusing.

  • use built-in variable parsing in php format

    Current nested variables in php config make it unexchangeable between differnt php projects. Because not all projects support this variable type. So I recommand using following way instead:

$baseDir="/var/webroot/project-root";
$cacheDir="${baseDir}/cache";
$tempDir="${baseDir}/tmp";
return array(
    'BASE_DIR' => $baseDir,
    'CACHE_DIR' => $cacheDir,
    'TMP_DIR' => $tmpDir,
);
  • make .env loader result as close as to shell parser result

In this way, the config files are more exchangeable.

from phpdotenv.

vlucas avatar vlucas commented on May 2, 2024

The new v2.0.0 release dropped the JSON and PHP loaders to standardize on shell-style only, which was the whole intent of this project in the first place. Please re-submit your changes based on the new v2.0.0 code, and we can review it for merge. Thanks!

from phpdotenv.

xjchengo avatar xjchengo commented on May 2, 2024

V2 finally released. I will send a pull request today.

from phpdotenv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.