🐛 [Bug] Missed Crit Suppression

[sh3ppard]

🐛 [Bug] Missed Crit Suppression

[sh3ppard]

I was wrong. It implemented, I found it in code:

core/src/game/Objects/Unit.cpp

Lines 2688 to 2693 in 5d27d09

	// Apply crit chance from defence skill
	int32 skillDiff = int32(GetWeaponSkillValue(attackType, pVictim)) - int32(pVictim->GetDefenseSkillValue(this));
	int32 minSkillValue = GetSkillMaxForLevel(pVictim) < GetWeaponSkillValue(attackType, pVictim) ? GetSkillMaxForLevel(pVictim) : GetWeaponSkillValue(attackType, pVictim);
	int32 cappedSkillDiff = minSkillValue - pVictim->GetDefenseSkillValue(this);
	crit += (pVictim->IsPlayer() || skillDiff > 0) ? skillDiff * 0.04f : cappedSkillDiff * 0.2f;

Also need to research about the crit suppression modifier which placed on total Critical Strike:

Modifiers to Critical Strike chance are reduced against enemies 3 levels higher than the player-character. There is a single modifier placed on total Critical Strike gained from auras that increase Crit chance.

Unfortunately Blizzard doesn't share that value.

Source

But guys from fightclub did some great work:

In addition, when fighting +3 level mobs there's a flat modifier placed on your total crit chance gained from auras. Auras in this context are talents such as Cruelty or Axe Specialization, gear that directly gives crit % through Equip: effects, buffs that increase you crit chance like Songflower Serenade or Leader of the Pack, and consumables such as Elixir of the Mongoose. It does not include crit gained indirectly through Agility, neither base Agility or Agility from gear.

While Blizzard only revealed the nature of this modifier but not its value, we've done extensive research with upwards of 60K hits and concluded that the modifier is most likely a flat 1.8% reduction to your crit chance gained from auras. If you don't have any crit from auras you are not affected by this, but still affected by the 3% suppression due to skill/defense difference mentioned above. Realistically, you will most likely have at least 2% crit from auras through one of the sources mentioned above even while leveling past level 10 (think 2/5 Cruelty) and certainly at level 60, putting your total suppression against +3 level mobs at 4.8%.

Source

This modifier should be ~1.8%.