Comments (2)
This is a very frustrating bug! It means that modal.close()
is unsafe! Now we have to guard against it?! Especially since the modal can close itself which means if you code calls close from an action hook your screwed!
from remodal.
I use a work around to handle this use case. It uses a Confirmer object to handle the complexity as follows:
function openModal() {
return new Confirmer(resolver => {
let inst = $('[data-remodal-id=modal]').remodal();
let promise = inst.open();
resolver.dispose(() => {
return promise.then(() => {
let modalState = inst.getState();
// https://github.com/vodkabears/Remodal/issues/291
if (modalState !== 'opened') { return; }
return inst.close();
});
});
});
}
from remodal.
Related Issues (20)
- Remodal inside Facebook iframe
- Remodal onload
- No longer actively maintained HOT 10
- Change responsibility web or mobile
- ***wrong post*** HOT 1
- blurry text when opening modal window HOT 2
- form label no checked
- you can use select2 in modal? HOT 3
- Check if modal has been closed once or destroyed HOT 2
- Multiple modal. HOT 1
- Won't trigger on SVG shapes in iOS (solution provided)
- Add no longer actively maintained message on plugin site HOT 1
- In IE11, remodal_obj.open() doesn't work properly
- Is there an React version of Remodal?
- New Functionality: send data to remodal from
- appendTo
- It's not working properly on Firefox for Mac HOT 2
- Chrome 80 HOT 1
- not working for netifly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from remodal.