Giter Site home page Giter Site logo

Comments (5)

voidful avatar voidful commented on June 3, 2024 1

I also find that repetition_penalty can cause that issue, so I removed that parameter in the latest version.

from textrl.

voidful avatar voidful commented on June 3, 2024

It is the latest version of textrl?
The issue could very likely be due to a significant update in the optimizer. Try adjusting the optimizer to see what effect it has.

from textrl.

tsaoni avatar tsaoni commented on June 3, 2024

it seems like the function top_k_top_p_filtering in the forward function of SoftmaxCategoricalHead class results in this error..?
it filters the value by replacing -inf, which causes loss_policy runs into nan

from textrl.

tsaoni avatar tsaoni commented on June 3, 2024

I'm sorry to bother but still want to ask,
is it reasonable to put top k top p filter inside the forward function? cause it would change the log probability when training
I suppose we only have to do it before sampling action?

from textrl.

voidful avatar voidful commented on June 3, 2024

I'm sorry to bother but still want to ask,
is it reasonable to put top k top p filter inside the forward function? cause it would change the log probability when training
I suppose we only have to do it before sampling action?

When we use model, we normally use top k top p sampling, my opinion is to align rl training to the actual usage.

from textrl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.