sml_server does not honour EOF when reading STDIN

[volkszaehler]

sml_server does not honour EOF when reading STDIN

[r00t-]

see also #32 (comment)

[r00t-]

fix goes here:
https://github.com/volkszaehler/libsml/blob/master/sml/src/sml_transport.c#L111

[devZer0]

did you test that with my binary dumps? fix does not work for me

[andig]

fix does not work for me

That's why its work in progress.

[devZer0]

sorry, that was not clear to me.

i found http://pubs.opengroup.org/onlinepubs/9699919799/functions/read.html
-snipp-
When attempting to read from an empty pipe or FIFO:
If no process has the pipe open for writing, read() shall return 0 to indicate end-of-file.
-snipp-

and added check for if read returns "0" likes see below.

that works for me, but i'm not sure if it's the correct way to handle that, i'm an awful bad programmer.

size_t sml_read(int fd, fd_set *set, unsigned char *buffer, size_t len) {

    ssize_t r = 0;
    size_t tr = 0;

    while (tr < len) {
            select(fd + 1, set, 0, 0, 0);
            if (FD_ISSET(fd, set)) {
                    r = read(fd, &(buffer[tr]), len - tr);
                    if (r == 0 )break;
                    if (r < 0 ) continue;

                    tr += r;
            }
    }
    return tr;

}

[andig]

Fixed by #51