Giter Site home page Giter Site logo

Comments (13)

jahir avatar jahir commented on June 23, 2024

Surely not. How can we prevent composer from installing it?

from volkszaehler.org.

andig avatar andig commented on June 23, 2024

Ups, I see. I'll create a fork and remove the docs.

Am 21.01.2015 um 00:23 schrieb jahir [email protected]:

Surely not. How can we prevent composer from installing it?


Reply to this email directly or view it on GitHub.

from volkszaehler.org.

andig avatar andig commented on June 23, 2024

Opened issue with owner: ztec/JpGraph#7

Meanwhile forged and updated jpgraph: https://github.com/volkszaehler/JpGraph/commits/master

Updated dependencies: #229

from volkszaehler.org.

r00t- avatar r00t- commented on June 23, 2024

let me try to clarify:

  • this is for a very rarely used feature, that most users don't know of and will never use
    (rendering graphs in the middleware instead of frontend)
  • imho this neither justifies downloding many megabytes, nor a managing a fork
  • does deleting files from git really reduce the download volume?
    matter of fact, it does not:
$ git clone https://github.com/ztec/JpGraph JpGraph_ztec
Receiving objects: 100% (2522/2522), 12.77 MiB | 2.94 MiB/s, done.
$ git clone https://github.com/volkszaehler/JpGraph JpGraph_vz
Receiving objects: 100% (2528/2528), 12.77 MiB | 4.47 MiB/s, done.  <---
18M JpGraph_vz
46M JpGraph_ztec
14M JpGraph_vz/.git
14M JpGraph_ztec/.git

isn't there a composer target that just downloads a release tarball?
and even that could be made optional

also: from what i can tell, that ztec version isn't even the official one...?
what makes it better, why do we use it over the one from jpgraph.net?
(other than that composer prefers pulling stuff from VCSes?)

from volkszaehler.org.

andig avatar andig commented on June 23, 2024

isn't there a composer target that just downloads a release tarball?

Nicht bekannt- und davon werden die Daten auch nicht weniger.

also: from what i can tell, that ztec version isn't even the official one...?

es gibt kein aktuelles Composer Package da das Projekt tot ist.

what makes it better, why do we use it over the one from jpgraph.net?

Weil es funktioniert.

Anders gesagt: Du kannst aus unserem JP Repo gerne alles rausschmeissen was Dich stört, ich weiss aber nicht was davon gebraucht wird...

from volkszaehler.org.

andig avatar andig commented on June 23, 2024

18M JpGraph_vz

Argh, natürlich- die Historie bleibt ja drin. Versuchs bitte nochmal, hab das Repo neu initialisiert.

from volkszaehler.org.

andig avatar andig commented on June 23, 2024

Wir könnten auch auf phantomjs umstellen. Das muss unter Windows aber von Hand installiert werden?

from volkszaehler.org.

jahir avatar jahir commented on June 23, 2024

Äh, phantomjs ist doch ein kompletter Browser, nur headless. Größenmäßig werden wir dadurch wohl eher nichts gewinnen...

from volkszaehler.org.

andig avatar andig commented on June 23, 2024

Für Windows 8MB, aber stimmt. Dafür gibts dann die gleichen schicken Charts wie im Frontend.

from volkszaehler.org.

andig avatar andig commented on June 23, 2024

ping

wir könnens auch einfach sein lassen, aber wenn ich mir die Mühe schon mache wäre Feedback wirklich das Mindeste :/

from volkszaehler.org.

mbehr1 avatar mbehr1 commented on June 23, 2024

+1

from volkszaehler.org.

r00t- avatar r00t- commented on June 23, 2024

i just noticed the problem and thought i'd report it.
i'm fine with any fix really.
so just merge #234 if you like

if you want my personal preference, then i'd make installing jpgraph optional and off by default. the feature is rarely used anyway.

from volkszaehler.org.

andig avatar andig commented on June 23, 2024

Closing as wfm.

from volkszaehler.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.