Comments (10)
I saw some chatter about this on IRC today. Is the report here the latest
update/status on the issue you are having?
On Mon, Jun 9, 2014 at 2:57 AM, Jonathan [email protected] wrote:
Some attributes in the puppetboard class are not quoted properly when
their values are written out to default_settings.py.This is my calling syntax, and for some variables I have had to
double-encapsulate strings in single quotes and double quotes, so they are
written out to default_settings.py with single quotes.class { 'puppetboard':
manage_virtualenv => true,
puppetdb_host => 'puppet.example.com',
puppetdb_port => "'8081'",
puppetdb_key => "'/var/lib/puppet/ssl/private_keys/${::fqdn}.pem'",
puppetdb_ssl => "'true'",
puppetdb_cert => "'/var/lib/puppet/ssl/public_keys/${::fqdn}.pem'",
}When these variables are not double-quoted, this happens in the apache log
because config values are written without quotes:[Mon Jun 09 08:57:12 2014] [error] [client x.x.x.x] PUPPETDB_KEY = /var/lib/puppet/ssl/private_keys/node.example.com.pem
[Mon Jun 09 08:57:12 2014] [error] [client x.x.x.x] ^
[Mon Jun 09 08:57:12 2014] [error] [client x.x.x.x] SyntaxError: invalid syntaxI'm using nibalizer-puppetboard 2.4.0 with Puppet 3.6.1. Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/nibalizer/puppet-module-puppetboard/issues/35.
Spencer Krum
(619)-980-7820
from puppet-puppetboard.
During the day I found that it is not necessary to quote integers like puppetdb_port => "'8081'"
. I still have to double-quote strings as in puppetdb_key
and puppetdb_cert
.
from puppet-puppetboard.
Can you provide a complete example of your instantiation class?
Thanks
On Mon, Jun 9, 2014 at 3:12 PM, Jonathan [email protected] wrote:
During the day I found that it is not necessary to quote integers like puppetdb_port
=> "'8081'". I still have to double-quote strings as in puppetdb_key and
puppetdb_cert.—
Reply to this email directly or view it on GitHub
https://github.com/nibalizer/puppet-module-puppetboard/issues/35#issuecomment-45550991
.
Spencer Krum
(619)-980-7820
from puppet-puppetboard.
What do you need that's not in my original post? That is the complete instantiation of class { 'puppetboard':
, the other stuff in my manifest does noddy things like add firewall rules.
from puppet-puppetboard.
I am poking at this now.
from puppet-puppetboard.
Couple early responses. Yes this is a bug, we should be handling the quoting for you. Second your invocation is wrong, you need to be passing in 'True' for the ssl_verify because that gets handed to python directly as a string. That could be considered a bug in the module probably. Also you need to pass it the certificate under puppetdb_cert not the private key. This file will be found at puppet config print hostcert
from puppet-puppetboard.
Hi @djjudas21 I've added quoting for the puppetdb_cert and puppetdb_key parameters. Setting the path to your ca file is still really janky. I've added documentation for this into the README and added some beaker tests as well.
Can you try #37 out? Or if it's been merged before you read this, can you try master as well?
Thanks,
Spencer
from puppet-puppetboard.
Hi, just picked up your message. The diffs look good to me but our puppet modules are all deployed from puppet forge directly, so it's hard to slipstream in non-official releases.
Thanks for your tips about what I'm passing in. I think I'd fixed most of these myself after talking to the the developer of puppetboard itself.
I'm heading off home for the weekend now but on Monday I'll have a think about deploying this test code without using puppet forge. Thanks for your effort checking this issue out.
Cheers,
Jonathan
from puppet-puppetboard.
I think we fixed this ya?
from puppet-puppetboard.
Yes, I'm happy with the latest code. Thanks!
from puppet-puppetboard.
Related Issues (20)
- Could not find resource HOT 4
- Support for AWS2 Linux?
- Puppet-python version dependency update HOT 1
- Allow OracleLinux as OS as same as CentOS/RedHat HOT 1
- No Module Named Flask HOT 1
- puppetboard has no explicit SELinux context for httpd HOT 2
- Debian 11 data targets incorrect system python version HOT 1
- Python version 3.8 incorrect for Debian 11 HOT 2
- Warning: The directory '/srv/puppetboard/puppetboard' contains 1936 entries, which exceeds the default soft limit 1000
- ModuleNotFoundError: No module named 'flask' on RHEL 8 HOT 5
- Path /srv/puppetboard/puppetboard exists and is not the desired repository HOT 6
- add support for ubuntu jammy - PR to accompany
- Please release 9.0.0 HOT 2
- Wrong SELinux type for wsgi.py, settings.py
- Unable to install version 4.0.3 on RHEL 8 using python 3.9
- Unable to install version > 3.6.1 on Ubuntu 18.04 using python 3.7 after module update HOT 10
- apache doesn't restart on an update to puppetboard
- Please release 9.1.0 HOT 2
- Need to keep the secret key HOT 4
- Drop support for EOL Ubuntu 18.04
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-puppetboard.