Status for pending changes - noop

[voxpupuli]

Status for pending changes - noop

[stack72]

@esbjerg are you sure this is not already in place? This PR was merged in a while back

https://github.com/nedap/puppetboard/pull/69

[esbjerg]

Well. Yes an no. I thought it was fixed in in #69 and I checked that the code from #69 is present in the puppetboard we use. However when we run node in noop mode puppetboard shows the status as None instead of Pending and the button stays grey.

I chatted with daenney on irc#puppet about it and he said #69 was not supposed to fix my issue.

Since it is not working at our puppetboard and daenney said it is not supposed to work that way I decided to create an issue.

I am working from 9-17 CET if you want to reach me - fx at irc#puppet.

[daenney]

Oh my mistake, #69 should at least make the noop nodes show up in 'blue' on the Overview page on the table so something might be wrong there.

But there's also the issue about showing noop resources in reports itself.

[tgc]

I just installed puppetboard from HEAD and also had this issue with noop events.
The problem looks to be that the pypuppetdb available on pypi (0.1.1) does not include this commit:
voxpupuli/pypuppetdb@3ab9da9

With that commit applied I now see noop reports counting as pending and being listed in blue as noop in the overview (as intended by #69)

[corey-hammerton]

PyPuppetDB 0.2.0 correctly sets a node or report's status to noop if the flag is it. This is only supported in PuppetDB 3.0 and up.

PuppetBoard will support this with the 0.1.0 release, stay tuned.

[corey-hammerton]

Noop status properly set with 709480a