Comments (4)
vshaxe/haxe-language-server#76 could maybe be applied there
from vshaxe.
Seems like problem with most actions is:
token.getPos()
returns offsets in utf8 (1 byte for abc
chars, 2 bytes for абв
chars)
and then document.rangeAt(pos.min, pos.max)
iterates with charAt
like arg offsets are single-byte
So there should be some way to convert utf8 byte offsets to characters first, before making range from it.
But Haxe4DisplayOffsetConverter
only offsets surrogates currently
from vshaxe.
Linked PR deals exactly with this on various commands (but not all that need it, apparently)
from vshaxe.
Lets rename byteOffsetToCharacterOffset
to utf16OffsetToCharacterOffset
and make separate utf8OffsetToCharacterOffset
?
It would be better to make int offsets as encoding-based abstracts, but this change can be too big.
from vshaxe.
Related Issues (20)
- Move class to own file
- Completion for haxelibs with no hxml
- Sort imports / usings ignores commented out imports / usings
- Error outlining not being shown HOT 1
- Go to Definition randomly selects blank space and "})", and then searches for those characters instead HOT 1
- Rename Symbol always return "could not find identifier to rename" HOT 3
- Rename symbol doesn't work for multi-root workspaces HOT 3
- IDE integration for custom define/metadata documentation HOT 1
- Completion not working with Properties
- `new` completion does not work for local types of a project HOT 1
- Error: Exec format error (haxelib path heaps hlsdl) HOT 4
- VSCode 1.78, 1.79: Fatal error: exception Failure("Couldn't connect on 127.0.0.1:6000") HOT 14
- Server recording disabled: could not remove previous files. HOT 4
- Switching to another file breaks completion since 4.3.0 / 2.27.0 HOT 1
- Hover request recieves completion response
- Autocompletion working unreliably with hxml includes HOT 2
- Dymanic capability registration not enabled, helix-editor reports
- Display constructor signature when hovering over class name in new expression HOT 2
- [Windows] Hxml cannot detect task with subfolder path
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vshaxe.