Giter Site home page Giter Site logo

JSX slot support about vue-docgen-api HOT 5 CLOSED

b12f avatar b12f commented on May 28, 2024
JSX slot support

from vue-docgen-api.

Comments (5)

elevatebart avatar elevatebart commented on May 28, 2024

This should be done in the slotHandler. And an e2e test should be useful.
Why not as well add a unit test so that debugging and fixing is easier?
For some reason I am hitting the same hickup as you are.

Recast doe not seem to cooperate well with JSX. I will dig more.
Thank you for the reminder

from vue-docgen-api.

b12f avatar b12f commented on May 28, 2024

Yeah I'll add e2e tests. I think for now I'll just add basic JSX support (<slot> tags anywhere in the current component) since this feature can easily grow out of proportions.

I don't see the code handling class-based components anywhere, as slotHandler.ts checks for objectExpression, not classExpression. I've thought about checking either/or, and then instead of checking inside of the render function only, visiting the whole component. Might take a small performance hit, but I think both classic createElement functions and JSX can occur outside of render(). Is that cool or would you like that in a second PR?

from vue-docgen-api.

elevatebart avatar elevatebart commented on May 28, 2024

I cooked up a little PR here if you want it as a starting point ;)

from vue-docgen-api.

elevatebart avatar elevatebart commented on May 28, 2024

Still need to be able to add the description though.

from vue-docgen-api.

vue-styleguidist-bot avatar vue-styleguidist-bot commented on May 28, 2024

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from vue-docgen-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.