Compatibility with PHP 7.4

[dualklip]

Compatibility with PHP 7.4

[Jamesking56]

I personally think this should match the latest nova version and not include any parameter types at all.

[vyuldashev]

Fixed by #161

[vyuldashev]

@dualklip I agree with @Jamesking56

[dualklip]

#161

[Jamesking56]

3.0.0 now breaks in PHP 8 for me with this:

PHP Fatal error:  Type of Vyuldashev\NovaPermission\Permission::$title must not be defined (as in class Laravel\Nova\Resource) in /home/runner/work/social-mind-platform/social-mind-platform/vendor/vyuldashev/nova-permission/src/Permission.php on line 166

laravel/nova version 3.25.0 (latest version)

[dualklip]

Thank you for the report @Jamesking56

Now I'm trying to figure out why these lines are the right solutions in each version and how to implement a solution for all versions:

PHP 7.3

public static $title = 'name';

PHP 7.4

public static string $title = 'name';

PHP 8.0

public static $title = 'name';

any idea?

[dualklip]

Seems like something has been resolved in Nova package, because the issue is not only related with the PHP version

laravel/nova:3.22+ php:7.4 = public static string $title = 'name';

laravel/nova:^3.25+ php:* = public static $title = 'name';

@vyuldashev How do you want face this issue? A removing to the v3.0.0 tag or a new PR with a rollback?