Giter Site home page Giter Site logo

Comments (8)

deniak avatar deniak commented on August 25, 2024

The proposed addition looks fine to me.
@plehegar @fantasai, any objection to add this?

from tr-design.

plehegar avatar plehegar commented on August 25, 2024

No objection from me but I sent an email to spec-prod just in case others have comments.

from tr-design.

svgeesus avatar svgeesus commented on August 25, 2024

Looks good to me.

from tr-design.

marcoscaceres avatar marcoscaceres commented on August 25, 2024

Respec uses .algorithm, so I wonder if we can make it work with that too?

from tr-design.

marcoscaceres avatar marcoscaceres commented on August 25, 2024

(Alternatively, Respec could recursively add data-algorithm to ol.algorithm… but be nice if it just works… in any case, please check that there isn’t going to be any style class with Respec specs)

from tr-design.

tabatkins avatar tabatkins commented on August 25, 2024

I can have bikeshed output a class=algorithm, that makes sense to me. (The data-algorithm attribute is just used for internal purposes currently and wouldn't have to be output if not for the styling use, but I'll be adding more structure soon.)

from tr-design.

marcoscaceres avatar marcoscaceres commented on August 25, 2024

Ok, cool. We can then rip out whatever Respec is adding for algorithms for custom style. Just needs a little coordination, but should be trivial and quick to do.

from tr-design.

plehegar avatar plehegar commented on August 25, 2024

@deniak , looks like we should be going with:

.algorithm:not(.heading) {
  padding: .5em;
  border: thin solid #ddd; border-radius: .5em;
  margin: .5em calc(-0.5em - 1px);
}
.algorithm:not(.heading) > :first-child {
  margin-top: 0;
}
.algorithm:not(.heading) > :last-child {
  margin-bottom: 0;
}
.algorithm .algorithm {
    margin: 1em 0;
}

from tr-design.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.