Comments (9)
My initial review draft: https://github.com/twirl/spec-reviews/blob/master/2013/10/Web%20Animations.md
from design-reviews.
@twirl thanks for doing this. It seems like you found a spec where we can really make a difference. Your critiques are very solid from what I can see reading the review alone. I will spend more time this weekend reading the spec to understand each of the critiques in more detail, and see if I can add to it. It is a very long spec, but also reasonably interesting, so hopefully that won't be so bad.
If you want to open a pull request then I can comment on particular lines more easily as I go through it. Otherwise we can certainly use this issue.
from design-reviews.
In fact, the largest part of the spec is a description of different types of animations; I read it not very carefully since I assume that spec authors are professionals in that area. But WebIDL part of the spec is sometimes weird; look at TimingItem - Timing - TimingInput relations. And I have some doubts that current CSS Transitions & Animations can be expressed in terms of Web Animations " without any observable change".
from design-reviews.
For "ISSUE: Inconsistent naming", the names in web animations actually match the new generation of DOM methods fairly well. See ChildNode, and children
also exists (it's the element child nodes). parent
seems inconsistent though, I agree.
Where are your slides? They had more than is present in the document.
Also: Blink is looking to implement a small subset of the full API. It would be good to scrutinize that subset to find issues in particular.
from design-reviews.
For "ISSUE: Inconsistent naming", the names in web animations actually match the new generation of DOM methods fairly well.
Agreed. But there still some differences:
DOM ParentNode: firstElementChild, lastElementChild, childElementCount
WA AnimationGroup: firstChild, lastChild, no "count" property
Where are your slides? They had more than is present in the document.
They are generally the same, except for one slide about computed style (which provoked the longest discussion, actually).
I'm working on incorporating F2F feedback into the draft right now.
from design-reviews.
I made a pull-request:
#27
It contains F2F feedback and it was actualized to match latest spec edition.
from design-reviews.
OK, I looked over the latest feedback draft, and it looks good to me.
I also looked closely at the subset Blink wants to ship, and it looks OK too, modulo the seconds -> milliseconds change which I believe the spec recently fixed. I also think onfinished
could be replaced with a .finished()
promise per w3ctag/promises-guide#25, so perhaps we should raise that as a possible idea.
I think we should merge it into this repo. I can then add my feedback about a .finished()
promise in a subsequent pull request.
I also think that, after my experiences in #3, we should add a disclaimer that this is work-in-progress feedback that we are collaborating on, and will present to the spec editors at a later date.
I think the next major thing is we need @slightlyoff's feedback, as he is closest to the team and familiar with the issues. At the f2f he said he'd look at a few issues, in particular the cloning stuff, if I recall.
In any case we should begin figuring out how best to approach the group to discuss these issues.
from design-reviews.
I've merged the draft into master
.
As for finished()
vs onfinished
- I'd prefer to have them both, since onfinished
event indicates exact moment of time when animation finishes while promise doesn't; it might be useful in some cases.
from design-reviews.
Discussed at London F2F; can close.
from design-reviews.
Related Issues (20)
- Captured Surface Control
- ServiceWorkerAutoPreload HOT 1
- `noopener-allow-popups` value in COOP HOT 3
- improvements to <details> styling (widget structure) HOT 3
- Spec review for scheduler.yield()
- Design Review: Prioritized Task Scheduling (big picture)
- Compression Dictionary Transport: Align on a single Content-Encoding for the web? HOT 3
- A layer attribute for layering of linked CSS style sheets in HTML
- Vibration API
- D
- Before 6 August 2023 -- Guidance on Applying WCAG 2 to Non-Web Information and Communications Technologies (WCAG2ICT) - Google Chrome - Daniel (w3.org)
- FedCM's IdP Registration API
- Fenced frames with local unpartitioned data access
- DOM state-preserving move
- Accessibility conformance Testing (ACT) Rules Format 1.1
- CSS reading-flow property
- Early design review: Future browsing context group dependency hint
- Dynamic import maps HOT 2
- Call stacks in crash reports from unresponsive web pages
- Early design review: Storage Access Headers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from design-reviews.