Giter Site home page Giter Site logo

Comments (13)

wade avatar wade commented on July 18, 2024

As stated in the ReadMe.md file, the version of this package does not have a hard dependency upon ILMerge and simply calls ILMerge.exe from the command line. You must supply ILMerge.exe and you may use any version that is compatible with the supported command-line arguments, which as of this writing, is ILMerge 2.14.1208 compatible, but also works with many preceding versions and versions that come after so long as no breaking changes have been made to the command-line interface. In fact, that is the entire purpose of this code/package - to loosely couple to ILMerge so that each time a new ILMerge version is released, one does not have to rebind to the assembly to simply integrate with it via MSBuild.

Just to restate more clearly, there is no direct binding or reference to ILMerge from this library nor does it depend upon any specific version of ILMerge nor does it have any direct dependencies upon any specific version of the ILMerge assembly/executable. You must provide your own copy of ILMerge that you obtain from another source (e.g. Microsoft's NuGet package).

Hope this helps,
Wade

from ilmerge.tools.

wade avatar wade commented on July 18, 2024

FYI, Mike Barnett created the ILMerge 2.14.1208 package after my request to change the NuGet package to not include ILMerge.exe in the content directory of the package but instead to include it in the tools directory. As far as I know, there is no significant difference between ILMerge 2.14.1203 and ILMerge 2.14.1208.

Wade

from ilmerge.tools.

XVincentX avatar XVincentX commented on July 18, 2024

That's the same thing I thought initially, but ILMerge.exe does not recognize.
/allowDuplicateResources, for example!

from ilmerge.tools.

wade avatar wade commented on July 18, 2024

I realized you may have been referring to the ILMerge.Tools NuGet package, which is a repack of ILMerge. I did just update that package to 2.14.1208. Let me know if that helps.

Wade

from ilmerge.tools.

XVincentX avatar XVincentX commented on July 18, 2024

I was referring to this one.
For ILMerge I am using the official one

Am I missing something?

from ilmerge.tools.

wade avatar wade commented on July 18, 2024

I see an error in my implementation that I will fix shortly for that command-line switch. It is passing "/allowDuplicateResources" instead of "/allowDup". Sorry for the confusion. I'll let you know once I have fixed it.

Wade

from ilmerge.tools.

XVincentX avatar XVincentX commented on July 18, 2024

Exactly! Great. I'll stay online!

from ilmerge.tools.

wade avatar wade commented on July 18, 2024

After going back through the code and the ILMerge documentation as well as performing a series of manual tests on the command-line, it appears that the ILMerge Word document does indeed list [/allowDuplicateResources] as an optional switch, the documentation does not elaborate on the switch nor does it list this option in the API reference. For versions 2.14.1203 and 2.14.1208, the documentation is the same and also for both versions, when you execute ilmerge.exe /? for the help, it does NOT display this switch. When this switch is applied to either version, the message, "Ignoring unknown option: 'allowDuplicateResources'," is displayed followed y the help text and the command does not execute.

This appears to be a discrepancy with ILMerge itself. I would contact Mike Barnett directly about it. I will likely remove the option from the MSBuild task since it does not work but instead causes an error.

The 'allowDup' switch is for the 'allow duplicate types' option, not the 'allow duplicate resources' option. Sorry I cannot be of more help on this issue.

Wade

from ilmerge.tools.

wade avatar wade commented on July 18, 2024

I have updated the source code and the corresponding NuGet package to version 2.14.1208 in which I have removed support for the "Allow Duplicate Resources" feature because it does not work in ILMerge.exe.

Wade

from ilmerge.tools.

XVincentX avatar XVincentX commented on July 18, 2024

Great.
Another point I discovered while using your package.
According to documentation, AllowDuplicateType can be called with null parameter too, which will allow any type to be renamed (see ilmerge.doc).

Actually, your code adds /allowDup options only for specific types. Do you think may you modify this behaviour too?

from ilmerge.tools.

wade avatar wade commented on July 18, 2024

Yes, I'll take a look at this later.

from ilmerge.tools.

wade avatar wade commented on July 18, 2024

I implemented support for the "/allowDup" switch without any specific type names with the new AllowDuplicateTypeNames which may be set to true to enable the switch. This is supported in the new release of the ILMerge.Tools.MSBuildToolTask package, version 2.14.1208.49.

Wade

from ilmerge.tools.

XVincentX avatar XVincentX commented on July 18, 2024

Definitely amazing! I'm going to try this one right now!

from ilmerge.tools.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.