Incorrect version in some distribution packages

[wader]

Incorrect version in some distribution packages

[wader]

@mpanczyk aha sorry! thought you might be the maintainer of this package https://pkgs.alpinelinux.org/package/edge/testing/x86_64/fq

[wader]

gojq does this by keeping the latest released in a go file https://github.com/itchyny/gojq/blob/main/cli/cli.go#L19 and also has a "revision" variable set to "HEAD" by default and is changed it building via make. Feel like a good solution i think.

[mpolanski]

This is now fixed on Alpine via alpinelinux/aports@1974aa4. I don't think that you need to change how the version string is set. A lot of software use goreleaser and pass some flags using ldflags. It's nothing wrong with that.

[wader]

@danfe @mpanczyk Hey, just published version 0.0.4 and it embeds the version so build flags is not needed anymore.

[Doctor-love]

Hmm, there is no way to include this information using standard "go build"?

[wader]

There is but not automatically, in go 1.18 go build will start to include some VCS information automatically i think. But that wont help for source archive builds. For binaries I currently i use goreleaser to pass go build flags to set the variable main.version.

I see that the nix builds sets verison https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/fq/default.nix#L24
but alpine does not https://git.alpinelinux.org/aports/tree/testing/fq/APKBUILD

I don't really follow how nix, alpine etc downloads the source, clones a git tag or downloads release archive?

I'll think and investigate a bit more, maybe can make goreleaser generate a version file while arching? but feels a bit ugly

[wader]

@mpanczyk hey, what do you think about this?

[mpanczyk]

@wader Sorry, but I think you have me confused with someone else.

[wader]

@mpolanski 👍 ill let you know if i switch to baking the version number into the source somehow, might be nice for ppl who build from source archives

[wader]

@danfe Looking at the freebsd ports Makefile i guess it also shows "dev" as version? if so, any preference to how to fix?

[danfe]

Looking at the FreeBSD ports Makefile I guess it also shows dev as version?

That's right, it does show dev when running fq --version.

If so, any preference to how to fix?

This is one of those things we lost upon entering modern era which replaced traditional, properly bootstrapped and $version expanded release tarballs with git tags (git does not even support keyword expansion which makes it even harder). Archived sources from GitHub (which packagers download, it's not the same as compressed git clone) do not contain any git metadata, so there's nowhere to derive version from (ditto for the commit hash). I personally simply edit files with sed(1) to fill in correct values prior to building. I can't think of an elegant solution (with git) other than generating proper release tarball like in the old times.

[wader]

This is one of those things we lost upon entering modern era which replaced traditional, properly bootstrapped and $version expanded release tarballs with git tags (git does not even support keyword expansion which makes it even harder). Archived sources from GitHub (which packagers download, it's not the same as compressed git clone) do not contain any git metadata, so there's nowhere to derive version from (ditto for the commit hash). I personally simply edit files with sed(1) to fill in correct values prior to building. I can't think of an elegant solution (with git) other than generating proper release tarball like in the old times.

Yeah i think your right. I will probably keep the latest release version in a file somehow. Also noticed now that goreleaser (a go release tool) seems to not produce source archives on it own, instead links to archive tags somehow, should look into that.

Thanks for your thoughts