Giter Site home page Giter Site logo

Comments (12)

snowcrash-arin avatar snowcrash-arin commented on May 28, 2024

To add more details, running convert_token a second time with a different backend token doesn't yield the same result. The issue only happens when running for the second time with the same backend token.

from drf-social-oauth2.

fahedmahidi avatar fahedmahidi commented on May 28, 2024

To add even more details : the second request fails.

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 28, 2024

Guys, you are clearly not reading the docs. This package has almost 12k downloads a month. Surely I have misconfigured the settings.

from drf-social-oauth2.

snowcrash-arin avatar snowcrash-arin commented on May 28, 2024

@wagnerdelima Can you provide details on which settings were misconfigured and confirm if you were able to replicate the issue? Just fyi, this behavior happens not only from curl, but also on the DRF API page.

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 28, 2024

@snowcrash-arin that's my concern exactly. I was not able to replicate the issue.

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 28, 2024

@fahedmahidi @snowcrash-arin FYI:
I completely misread this issue. In your instructions, you added "Run curl with -i parameter(-i shows header contents)". Yes, it will add the headers in the response because you are passing -i:

image

from drf-social-oauth2.

snowcrash-arin avatar snowcrash-arin commented on May 28, 2024

@fahedmahidi @snowcrash-arin FYI: I completely misread this issue. In your instructions, you added "Run curl with -i parameter(-i shows header contents)". Yes, it will add the headers in the response because you are passing -i:

image

Hi @wagnerdelima

If you look at the screenshot, it shows user environments, not just the headers, which is security concern. Additionally, I made note of the fact that this issue is occurring on the DRF API page.

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 28, 2024

@snowcrash-arin what do you mean by "DRF API page"?

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 28, 2024

I am investigating this issue @snowcrash-arin. So far I have got no clue on how to solve it. Any ideas will be welcome.

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 28, 2024

@snowcrash-arin @fahedmahidi I believe this is fixed now. Please retest it with the latest published version 2.1.1.

Also, check the newly published readthedocs page: https://drf-social-oauth2.readthedocs.io/en/latest/

from drf-social-oauth2.

snowcrash-arin avatar snowcrash-arin commented on May 28, 2024

Thanks @wagnerdelima! I'll test it and let you know sometime this month. I stopped working on it due to the security concern.

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 28, 2024

@snowcrash-arin please do! Let me know :)

from drf-social-oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.