Giter Site home page Giter Site logo

Comments (7)

Kdecherf avatar Kdecherf commented on June 3, 2024 1

Hey @HolgerAusB,

In French the question mark must be preceded by a non-breaking space

from wallabag.

HolgerAusB avatar HolgerAusB commented on June 3, 2024 1

Thank you. I removed the string_replace.
You may close this issue.

from wallabag.

HolgerAusB avatar HolgerAusB commented on June 3, 2024

Hi @j0k3r, a question about French language. Is it allowed or common to have a space before a question mark in a question?

This article contains several subheadings that ends with 'some text ?' instead of 'some text?' which caused wallabag in some cases to wrap the question mark only to the next line.

I therefore striped that space to make it better readable. If that space is allowed in French, we could replace it with an  

from wallabag.

HolgerAusB avatar HolgerAusB commented on June 3, 2024

Thank you - and I think it is the same with exclamation marks?

I am a bit anxious if I should replace all " ?" with " ?" or only those at the very end of all subheadings? Could be dangerous, or?

replace_string( ?): ?
replace_string( !): !

or

replace_string( ?</h):&nbsp;?</h
replace_string( !</h):&nbsp;!</h

or

leave it as is? What do you mean.

Edit 1: Too dangerous, is to that replacement for colon :

Edit 2: Or should I use a 'narrow not-breakable space' &#8239; instead of &nbsp; as I just learned

from wallabag.

j0k3r avatar j0k3r commented on June 3, 2024

To be fair, I don't think it's that important to handle it.
I just tested your site config, and it doesn't shock me if ? has no breaking space before.

image

from wallabag.

HolgerAusB avatar HolgerAusB commented on June 3, 2024

@j0k3r I got that break at: 4. Quels avantages à être un actionnaire salarié ? Of course, you must remove my replacement in the config to see ;-)

grafik

from wallabag.

j0k3r avatar j0k3r commented on June 3, 2024

Isn't because of the size of the page? It's ok for me if the ? goes on a new line like you have

from wallabag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.