Crash with OkHttp error: `IllegalStateException: cannot make a new request...`

[rafaelekol]

Crash with OkHttp error: `IllegalStateException: cannot make a new request...`

[jakubuid]

@rafaelekol thank you! We'll look into this ASAP

[TalhaAli00]

@rafaelekol we're still investigating a solution to enable failover for both our Http client and websocket client

[rafaelekol]

Function coreAndroidNetworkModule() in CoreNetworkModule.kt file contains multiple calls chain.proceed() which can cause such error.
I couldn't reproduce this error with your sample app.

[abdrasulov]

It may be the same issue as described here

https://stackoverflow.com/questions/76287902/java-lang-illegalstateexception-cannot-make-a-new-request-because-the-previous

[jakubuid]

The newest version is 1.21.0. Can you upgrade and see if this still persists?

[rafaelekol]

@jakubuid I tried to update until version 1.21.0.
But it didn't help. I am getting same error.

[jakubuid]

Can you provide reproduction steps?

[rafaelekol]

@jakubuid
Inside this class com.walletconnect.android.internal.common.di.CoreNetworkModule I added 2 lines of code to reproduce
crash that is happening in our project.

@Suppress("LocalVariableName")
@JvmSynthetic
fun coreAndroidNetworkModule(serverUrl: String, connectionType: ConnectionType, sdkVersion: String, timeout: NetworkClientTimeout? = null) = module {
    val DEFAULT_BACKOFF_SECONDS = 5L
   ...

single(named(AndroidCommonDITags.FAIL_OVER_INTERCEPTOR)) {
        Interceptor { chain ->
            val request = chain.request()
            try {
                val host = request.url.host

               //I added these 2 lines
                chain.proceed(request)
                throw SocketException("test")

                when {
                    shouldFallbackRelay(host) -> chain.proceed(request.newBuilder().url(get<String>(named(AndroidCommonDITags.RELAY_URL))).build())
                    shouldFallbackPush(host) -> chain.proceed(request.newBuilder().url(getFallbackPushUrl(request.url.toString())).build())
                    shouldFallbackVerify(host) -> chain.proceed(request.newBuilder().url(getFallbackVerifyUrl(request.url.toString())).build())
                    else -> chain.proceed(request)
                }
            } catch (e: Exception) {
                if (isFailOverException(e)) {
                    when (request.url.host) {
                        DEFAULT_RELAY_URL.host -> fallbackRelay(request, chain)
                        DEFAULT_PUSH_URL.host -> fallbackPush(request, chain)
                        DEFAULT_VERIFY_URL.host -> fallbackVerify(request, chain)
                        else -> chain.proceed(request)
                    }
                } else {
                    chain.proceed(request)
                }
            }
        }
    }

...

[rafaelekol]

Hi, any updates on this issue?

[TalhaAli00]

@rafaelekol are you able to tell us if you saw this issue in a Debug build or on a Release build?

[rafaelekol]

@TalhaAli00 This crash is steadily happens when I try to increase your Release library higher than 1.15.0.
We suspect that issue lies in combination of other network libraries that we use in our App with your SDK.

[rafaelekol]

@TalhaAli00 Any progress on this bug?
This issue is holding us from updating your SDK in our wallet.

[TalhaAli00]

Hello @rafaelekol
We've been able to focus time to resolving this issue. There's a PR #1365 where I've able to make sure that the interceptor isn't leaving a response open when switching over during the failover logic. We'll be releasing a new version this week with this fix

[rafaelekol]

@TalhaAli00 thats great news 👍🏼