Giter Site home page Giter Site logo

Comments (10)

wallin avatar wallin commented on August 25, 2024

Hi, thanks for reporting this. Which version of angular are you using more specific?
I'll take a look and try to fix it!

from angular-gravatar.

henrik avatar henrik commented on August 25, 2024

Thank you! I'm on v1.0.2.

from angular-gravatar.

henrik avatar henrik commented on August 25, 2024

…so I guess 1.2 was entirely inaccurate :) Sorry. I see I accidentally got the wrong version of a Ruby gem that pulls in Angular for me.

from angular-gravatar.

henrik avatar henrik commented on August 25, 2024

Works fine on 1.2.16. Sorry about that!

from angular-gravatar.

wallin avatar wallin commented on August 25, 2024

Right! No worries! So I'll just close the issue then?

from angular-gravatar.

henrik avatar henrik commented on August 25, 2024

Guess so, unless you want to support 1.0.2 :)

from angular-gravatar.

henrik avatar henrik commented on August 25, 2024

If you don't want to support it but want to be super friendly I guess you could show a helpful error message if the version is too low.

from angular-gravatar.

wallin avatar wallin commented on August 25, 2024

I fixed it (figured why not). As a bonus the file is now 2 bytes smaller! =)

from angular-gravatar.

henrik avatar henrik commented on August 25, 2024

:) I don't remember whether I tried without the array in 1.2 but it would be weird if that broke anything. Thanks for fixing!

from angular-gravatar.

wallin avatar wallin commented on August 25, 2024

Yup! well, the tests pass with 1.2.x so it should be fine!
Have a nice day!

from angular-gravatar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.