Giter Site home page Giter Site logo

Comments (20)

wangwenx190 avatar wangwenx190 commented on June 3, 2024

Several people told me about this issue, it seems the startSystemResize() function is unusable on macOS.

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

See: https://doc.qt.io/qt-5/qwindow.html#startSystemResize

from framelesshelper.

skarndev avatar skarndev commented on June 3, 2024

Yeah, thanks for pointing the issue out. Is there a way to track those mouse movements on the edge manually?
It seems we can check against system resize support by doing this:

if (!window.startSystemResize(edges)) {
// fallback code for setting window.width/height manually
}

It should return false if not supported.

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

Yeah, thanks for pointing the issue out. Is there a way to track those mouse movements on the edge manually?
It seems we can check against system resize support by doing this:

if (!window.startSystemResize(edges)) {
// fallback code for setting window.width/height manually
}

It should return false if not supported.

Sounds reasonable. I'll try to implement this.

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

Now I know the frameless window can't be resized, but can it be moved by dragging the custom title bar?

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

New commit uploaded. Can you test the latest code?

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

If this issue still exists, please inform me.

from framelesshelper.

skarndev avatar skarndev commented on June 3, 2024

Now I know the frameless window can't be resized, but can it be moved by dragging the custom title bar?

Yes, it works. It also gets resized by double clicking on the titlebar.

If this issue still exists, please inform me.

Yes, the issue still exists. It does resize now, but does not resize with delta, it jumps to a certain extent. The video is below.
https://youtu.be/l3NAXiTq9Ow

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

Now I know the frameless window can't be resized, but can it be moved by dragging the custom title bar?

Yes, it works. It also gets resized by double clicking on the titlebar.

If this issue still exists, please inform me.

Yes, the issue still exists. It does resize now, but does not resize with delta, it jumps to a certain extent. The video is below.
https://youtu.be/l3NAXiTq9Ow

OK, I see. I'm working on it.

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

New commit uploaded. Can you test the latest code? I suggest you try more test cases: top bottom left right top-left top-right bottom-left bottom-right

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

I don't have a mac so I'm relying on my imagination to debug this code. I want to see a screen record if possible, thanks.

from framelesshelper.

skarndev avatar skarndev commented on June 3, 2024

New commit uploaded. Can you test the latest code? I suggest you try more test cases: top bottom left right top-left top-right bottom-left bottom-right

Nope. Very wrong now. I suggest you turn off system resize logic for your case temporarily, so you can test it on your machine more easily.

https://youtu.be/xxApuQhrsKQ

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

New commit uploaded. Can you test the latest code? I suggest you try more test cases: top bottom left right top-left top-right bottom-left bottom-right

Nope. Very wrong now. I suggest you turn off system resize logic for your case temporarily, so you can test it on your machine more easily.

https://youtu.be/xxApuQhrsKQ

It does look very strange now. Working on it.

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

I made a bug report to the Qt company: https://bugreports.qt.io/browse/QTBUG-88218

If the Qt company are not willing to fix it in the near future, I'll implemenet an alternative solution.

from framelesshelper.

skarndev avatar skarndev commented on June 3, 2024

I made a bug report to the Qt company: https://bugreports.qt.io/browse/QTBUG-88218

If the Qt company are not willing to fix it in the near future, I'll implemenet an alternative solution.

Afaik it is not supported on other platforms as well. The other machine this was tested on running on Debian/GNOME/X11. Also returns false. Works on Windows though.

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

Afaik it is not supported on other platforms as well. The other machine this was tested on running on Debian/GNOME/X11. Also returns false.

I tested this repo on Fedora KDE (X11) and it works well. And it should not return false on Linux:

图片

from framelesshelper.

skarndev avatar skarndev commented on June 3, 2024

Afaik it is not supported on other platforms as well. The other machine this was tested on running on Debian/GNOME/X11. Also returns false.

I tested this repo on Fedora KDE (X11) and it works well. And it should not return false on Linux:

图片

Maybe the issue is tied to GNOME environment?

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

Maybe the issue is tied to GNOME environment?

Not sure. I didn't test in GNOME. One point: recent versions of GNOME is using Wayland instead of X11.

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

Sadly the Qt engineer told me it's not possible to implement startSystemResize() on macOS. I'm not a macOS developer, so I don't know why, but it sounds like a technical limitation.

from framelesshelper.

wangwenx190 avatar wangwenx190 commented on June 3, 2024

Fixed in 2.0

from framelesshelper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.