Compiler warnings in driver-gekko.c that aren't obvious how to fix.

[chipjarred]

Compiler warnings in driver-gekko.c that aren't obvious how to fix.

[wareck]

thanks for you work.
i'm working on it, , add your fixes and made some modification for windows compilation
for macos I haven't test it yet
best regards
olivier

[chipjarred]

I'm not sure if you saw, but I had also submitted a pull request, which I then closed because it contained a boneheaded mistake (a memory leak that wasn't). But it also contained a valid fix, and I haven't resubmitted. cgminer.c calls subscribe_extranonce(), which is defined in util.c, but util.h doesn't contain a prototype for it, which triggered an illegal implicit prototype error, preventing the build. Obviously the fix is simply just adding the prototype to util.h.

Not in that pull request are fixes to util.c for references to interrupted() that emit warnings because they are just references to the function name rather than a call to the function, which of course evaluates to a function pointer rather than the function's return value. Since those instances are part of if conditions, the function pointer always evaluates to true. It's clear from the code's context that's actually trying to handle an interruption rather than detect a valid function pointer, plus it's an idiom used in several other places in the code where it actually does call the function.