Units Attacking from Transporter Use Wrong Tile Size

[wargus]

Units Attacking from Transporter Use Wrong Tile Size

[timfel]

(by iddqd-mail)
Check, if this was fixed in rev.8959

[timfel]

(by andre-ng)
I tried out the fix, but unfortunately it seems that it didn't work :( I tried putting archers (range 4) in a garrisonable building of 4x4 tile size, and they could still only attack units to the south of the building that were adjacent to the building (meaning that the range is being counted without taking into account the building's larger tile size).

[timfel]

(by iddqd-mail)
Another fix in rev.8961, check, if that bug has been fixed.

[timfel]

(by andre-ng)
cybermind, thanks for your attention in trying to fix this bug. I tested the fix in revision 8961, and unfortunately it did not solve the issue. Everything happens exactly the same as before.

[timfel]

(by iddqd-mail)
Could you upload a test map or something to show this bug?

[timfel]

(by andre-ng)
I managed to pinpoint the reason for the bug. It was in the function MapDistanceTo(const CUnit &dst) in unit.h. Here is a fixed version of the function:

int MapDistanceTo(const CUnit &dst) const
{
    const CUnitType *distance_unit_type = Container ? Container->Type : Type;
    return MapDistanceBetweenTypes(*distance_unit_type, tilePos, *dst.Type, dst.tilePos);
}

I have tested it and can confirm this fix works.