Comments (5)
Thanks - do you know if that also an issue with the deserialization functions where we do this?
size_t deserialize16(const unsigned char *buf, uint16_t *data)
{
*data = ntohs(*reinterpret_cast<const uint16_t *>(buf));
return sizeof(*data);
}
from stratagus.
Yes, the same exact reasonning also applies.
Assigning through a non-aligned pointer is undefined behaviour, and will mislead the optimizer, which will make the assumption that the pointer is properly aligned.
Using memcpy
solves this issue because a call to memcpy
isn't an assignment, and thus, doesn't require anything on the alignment. Thus the compiler won't make wrong assumptions here.
from stratagus.
@Ace17 thanks a lot for the pointers, could I bother you to take a peek at https://github.com/Wargus/stratagus/pull/426/files where I tried to fix these issues where I could find them?
from stratagus.
Hi @timfel , this definitely looks good to me! 👍
from stratagus.
Thank you!
from stratagus.
Related Issues (20)
- try to build with /usr/include/lua.h rather than /usr/include/lua-5.1/lua.h (I think) HOT 2
- Documentation typo/incorrect information? HOT 6
- Unexpected behavior when upgrading units to units with lower maximum health HOT 1
- Stratagus failed to load game data. HOT 1
- build stratagus make fatal error: mdns.h HOT 5
- Broken CI with icon with linuxdeploy HOT 2
- Network Desync. HOT 7
- Red Humans Glitch when loading games, followed by a Crash. (War1gus)
- crash on startup HOT 5
- PLEASE modify the uninstaller
- Warcraft 3 HOT 1
- [macOS] Regression: Black text on main menu in Wargus (Stratagus bug) HOT 5
- Crash to desktop when upgrading/morphing unit that is carrying resources into one that cannot
- [CRASH][wc1] Assertion failed RefsIncrease: !Refs || (Refs && !Destroyed) HOT 1
- Trigger: LoadGame memory issue by adding more triggers
- Pathfinder: Bad handling of failure results HOT 1
- [macOS] Crash when exiting program - Wargus & War1gus HOT 1
- edge scroll (down+right only) broken HOT 3
- Crash on end of mission. Backtrace
- cursor.h:137 error: field ‘Ident’ has incomplete type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stratagus.