Giter Site home page Giter Site logo

Comments (4)

WarmUpTill avatar WarmUpTill commented on September 25, 2024 1

I would simply merge both.
I can't see any obvious conflicts.

from sceneswitcher.

Destroy666x avatar Destroy666x commented on September 25, 2024

Never mind. Just noticed this is a different bug/not great behavior. I was not authenticated (I guess loading backup removed the token or it expired). But it showed that nowhere in the UI. I remember there was a red warning for insufficient permissions. I think it should also cover the case of losing authentication.

from sceneswitcher.

WarmUpTill avatar WarmUpTill commented on September 25, 2024

I added more warnings in the linked PR, which will display a warning if the token is expired or no token is selected at all.

from sceneswitcher.

Destroy666x avatar Destroy666x commented on September 25, 2024

Ah. I see we made PRs with different approaches:

  • yours has better UX and messages
  • mine has better coverage as there are more places that use those token checking functions

Something in the middle would probably be best

from sceneswitcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.