CilInstruction.Offset is always 0

[AnErrupTion]

CilInstruction.Offset is always 0

[Washi1337]

For performance reasons, offsets are not automatically calculated. You can trigger offset calculation using Instructions.CalculateOffsets().

See also: https://asmresolver.readthedocs.io/en/latest/dotnet/managed-method-bodies.html#finding-instructions-by-offset

[Washi1337]

Why not calculate them each time an instruction is added to the list? Does this still cause performance issues?

@AnErrupTion Yes. Calculating the offset of a new instruction at the end of the list may be relatively easy (i.e., just get the last instruction's offset + size), but anything more substantial (e.g., inserting in the middle or removing an instruction) will require an O(n) operation to refresh all offsets. Given that typically offsets aren't really that important in CIL anyways, this design choice was made.

[AnErrupTion]

For performance reasons, offsets are not automatically calculated. You can trigger offset calculation using Instructions.CalculateOffsets().

See also: https://asmresolver.readthedocs.io/en/latest/dotnet/managed-method-bodies.html#finding-instructions-by-offset

Why not calculate them each time an instruction is added to the list? Does this still cause performance issues?

[AnErrupTion]

Why not calculate them each time an instruction is added to the list? Does this still cause performance issues?

@AnErrupTion Yes. Calculating the offset of a new instruction at the end of the list may be relatively easy (i.e., just get the last instruction's offset + size), but anything more substantial (e.g., inserting in the middle or removing an instruction) will require an O(n) operation to refresh all offsets. Given that typically offsets aren't really that important in CIL anyways, this design choice was made.

That makes sense :p