Comments (26)
Hello @aditi10701 !
I would love to work on this issue. Could you please assign it to me and let me know what footer is expected ?
from book-finder.
hey can you assign this to me
from book-finder.
Hello , I want to contribute in this issue , can you please assign to me?
from book-finder.
hey @aditi10701
pls assign this issue to me
from book-finder.
hey it's a joint assigned so, other contributors how you are going to do please tell me
from book-finder.
A footer of such type can be added
from book-finder.
can you share social media links to be added
from book-finder.
It will be based on the project owner details.
from book-finder.
exclude social media links
from book-finder.
sure
from book-finder.
from book-finder.
Hi @wasimreja !
Why it has been reassigned? 🥲
from book-finder.
Hello, can i work on this issue please, i would like to redesign this footer and further work on it!
from book-finder.
Hello @wasimreja,
Could you review my PR, please ? #137
Thank you.
from book-finder.
keep the background similar to nav bar, remove terms & conditions, privacy policy, align copyright to center
from book-finder.
@wasimreja Hi!
Could you review my PR , please ? #137
from book-finder.
@mnosov622 make the necessary changes as i said
from book-finder.
@mnosov622 make the necessary changes as i said
Sure, got it !
from book-finder.
keep the background similar to nav bar, remove terms & conditions, privacy policy, align copyright to center
is the footer fine?
I made the necessary changes.
should I send a pull request?
from book-finder.
Guys, maybe we all make small changes so that everyone could contribute ?
from book-finder.
This is something that I tried doing, you just need to add the links and change icons for the desired social media icons, also if you can provide links it would be great, I will do it by myself.
All icons including the BookFinder text changes color while you hover too.
from book-finder.
Is this issue still open to work on ?
from book-finder.
Is this issue still open to work on ?
yes!
from book-finder.
Wasim bro, I kind of agree with mnosov622, we should try to make small changes, so everyone gets a chance, will you be merging my pr or should I make necessary changes as you told?
from book-finder.
Wasim bro, I kind of agree with mnosov622, we should try to make small changes, so everyone gets a chance, will you be merging my pr or should I make necessary changes as you told?
do the changes to footer, i'll merge it. no need to work on about page.
from book-finder.
@wasimreja I already did footer, could you merge my PR, please ?
Other people could fix it and make it look better.
from book-finder.
Related Issues (20)
- Add pagination HOT 7
- Create a 404 error page HOT 3
- Pre-Loader
- Redirect book not found to 404 page HOT 3
- Add Logo on Navbar HOT 1
- Improve the about us page
- Create a contact us page HOT 2
- Create features page HOT 2
- Fix pagination functionality HOT 2
- Revamp Contact Page HOT 2
- Revamp feature page HOT 1
- Add FAQ page
- Add badges in readme HOT 1
- Language Translator HOT 1
- Update contributors HOT 1
- Pagination display HOT 1
- Faq illustration HOT 2
- Adding FormSubmit to Contact Us page
- Error Page Responsiveness
- Email verifivation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from book-finder.