Giter Site home page Giter Site logo

`abortOnCannotGrowMemory` has the wrong type signiture, `_emscripten_get_heap_size` and `_emscripten_resize_heap` missing about wasmer HOT 5 CLOSED

wasmerio avatar wasmerio commented on May 4, 2024
`abortOnCannotGrowMemory` has the wrong type signiture, `_emscripten_get_heap_size` and `_emscripten_resize_heap` missing

from wasmer.

Comments (5)

syrusakbary avatar syrusakbary commented on May 4, 2024

Taking a look now.
It seems memory management changed a bit: emscripten-core/emscripten@1655d72

I think is feasible to support both cases (old-emscripten files, and new ones)

from wasmer.

davidMcneil avatar davidMcneil commented on May 4, 2024

Compiling with emscripten version 1.38.21 fixes the issue.

from wasmer.

davidMcneil avatar davidMcneil commented on May 4, 2024

This is by no means a complete solution, but it gets the tests to pass https://github.com/davidMcneil/wasmer/tree/172. I would be happy to put this into a more formal pull request. What would be the best way to determine the type signature of abortOnCannotGrowMemory to use?

from wasmer.

syrusakbary avatar syrusakbary commented on May 4, 2024

Thanks for the changes @davidMcneil.

I've created the PR #173 to add a comment to have compatibility for both functions:
#173

(any change in your branch will be reflected in the PR)

from wasmer.

syrusakbary avatar syrusakbary commented on May 4, 2024

Closing the issue, as is fixed with #173

from wasmer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.