Giter Site home page Giter Site logo

Comments (5)

daleeidd avatar daleeidd commented on June 8, 2024 1

Thanks for the detailed report! It was indeed a bug. LOD data should always blend out when nearing the end of the LOD chain. This isn't ideal as some configurability would be good but fixing it is good enough for now.

from crest.

daleeidd avatar daleeidd commented on June 8, 2024 1

Yes, I understand the implications of the change.

Anyway, the future wasn't that far away as I have already done it.

from crest.

Revmatek avatar Revmatek commented on June 8, 2024

Thanks for the detailed report! It was indeed a bug. LOD data should always blend out when nearing the end of the LOD chain. This isn't ideal as some configurability would be good but fixing it is good enough for now.

I took at look at this just now, and it does seem to fix the delay, however it also seems to introduce a problem where the clipping area is no longer respected and the tiles can appear inside the area when below:

Below:
image

Above:
image

Its easier to see with a cube at the edge. Without the cube its hard to notice, but still happens.

from crest.

daleeidd avatar daleeidd commented on June 8, 2024

That's expected. Default behaviour for all LOD data is to blend out between last set of tiles. A better approach for certain data would be to just prevent the data from bleeding over into the extents which is something I will look at doing in the future.

from crest.

Revmatek avatar Revmatek commented on June 8, 2024

That's expected. Default behaviour for all LOD data is to blend out between last set of tiles. A better approach for certain data would be to just prevent the data from bleeding over into the extents which is something I will look at doing in the future.

I think understand what you are saying. To clarify though, it still requires setting the LOD higher (7->8) in my case. To ramble on a bit, I cannot use the clipping areas if it shows inside the area because it would appear water is leaking through something such as a water dam / drydock. So I am ok just setting the LOD higher to fix it for my needs. I don't think there is a case where this would show correctly in such a scenario with this change, adjusting the LOD in some way or maybe like a flag... but maybe that wouldn't really help. I'm not really sure what the answer is, but blending by default (at least for me) will cause problems, it works fine with LOD set to 8 instead of 7, delay. I guess I was expecting it to work with LOD 7 since it appeared correctly previously but was delayed, now it will not appear correctly unless I use 8. But I am ok using 8 so maybe it is a nonissue, but it feels sorta like trade between it not showing one part vs another at LOD 7 and both require a higher LOD (maybe that is fine).

from crest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.