Comments (5)
You're right, Wave should definitely include support for these! I completely missed this when doing the original implementation
At present, when parsing we just hash the whole configmap/secret for simplicity's sake, so I'd be tempted to start with a PR to add the parsing of the envVar
section and just adding the whole secret/configmap (as we do with other sources) and then follow up with a second PR which makes the changes to only hash the individual keys within the secrets and configmaps.
WDYT?
from wave.
That's a possibility, yes, and I might be able to whip up a quick PR, but for our use case we'd want the final behaviour of spotting individual key changes.
I'm really close to finishing the code that handles specific keyed items: I've just got to handle the optional field and those fields being potentially missing (and extend the unit tests for that situation).
from wave.
PR submitted (#34) that includes the env
section, only using the specified keys in the hash, and handling the optional
flag as best I can.
from wave.
@andyedwardsdfdl Can this issue be closed now #34 is merged?
from wave.
Yep, I believe this is now resolved, and ready to go into the next release.
from wave.
Related Issues (20)
- use rbac.authorization.k8s.io/v1 HOT 7
- Wave is not starting the stateful set pods HOT 2
- helm installation instructions don't work HOT 9
- Does wave support Kubernetes Jobs HOT 2
- Helm chart installation fails on Kubernetes v1.23.6+k3s1 HOT 1
- changes to projected volumes not detected properly HOT 3
- v1beta1 resource not available change to v1 to make crds work on helm install HOT 9
- non-rolling update, i.e. kill pod before starting new HOT 2
- Can't deploy helm chart on k8s version >v1.22 HOT 5
- [helm] Cannot install chart in kubernetes 1.25 HOT 2
- [Question] Any security issues to consider? HOT 1
- Wave Removes StartupProbes HOT 4
- New and motivated project member HOT 8
- Support for releases / tags HOT 2
- Getting rid of ownerReferences and finalizers
- Website is outdated HOT 1
- Upgrade to 4.1 fails HOT 4
- Children Tracking Issue: Required and Non-Required Keys are mixed up
- Children Tracking Issue: Multiple references to the same child overwrite each other
- Children Tracking Issue: Wave does not verify if all keys exist in required children
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wave.