Comments (10)
Why shouldn't it stretch the whole width?
from awesome-learning.
@leira-sanchez On larger screens, it's hard to read the content of the webpage if the content takes up everything that it can. It reduces eyestrain and the amount of real estate that a visitor needs to physically read in order to digest what's on a page.
from awesome-learning.
couldn't you just target the body for a set width via media query? e.g.
CSS:
@media screen and (min-width:960px) {
body { max-width: 960px !important; }
}
from awesome-learning.
that would be the idea. It would only take effect for larger browsers, smaller browsers who need all of the width will not be affected. I think we already have some sort of max width for our lesson page, just want to make sure it gets put on other pages as well.
from awesome-learning.
Can I work on this for the Hacktoberfest contest?
from awesome-learning.
Yes, feel free to go for it @Prateek93a !
from awesome-learning.
Thanks
from awesome-learning.
@Prateek93a Are you still working on this issue? If not, please let me know, so that I can unassign you from this issue.
from awesome-learning.
Hai, Please check the PR #116 have made the tweak, I have added the size as 80%
from awesome-learning.
@SheaBelsky Sorry Sir I am not currently working on it. Kindly assign it to someone else.
from awesome-learning.
Related Issues (20)
- Create a contribution guide with our general coding standards
- package-lock.json has merge conflict markers HOT 1
- Add Custom Theme to storybook
- Look into Atomic Design to refactor our shared components
- Add visual regression testing to storybook HOT 1
- Quiz contribution missing from README
- Add "module" query parameter to lessons
- Implement brief summary for courses/lessons/content
- [Redesign] Create Global Variables in SCSS HOT 4
- [Redesign] Create Clickable Card Component HOT 5
- [Redesign] Create Base Button Component HOT 4
- [Redesign] Update maximum width of Navigation to stop growing at 1600px HOT 3
- [Redesign] Update maximum width of Layout to stop growing at 1600px HOT 4
- [Redesign] Create "Featured Course" component
- [Redesign] Create Landing page UI component and template HOT 3
- [Redesign] Update SectionTitle component HOT 1
- [Redesign] Add "What is Awesome Learning" and "How to get started" section to Landing HOT 1
- [Redesign] Add Primary CTA to Landing
- Pre-work link is dead HOT 3
- Broken Link for Implicit Coercion HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from awesome-learning.