[wf-background] crash if background image path contains parentheses

[dkondor]

[wf-background] crash if background image path contains parentheses

[dkondor]

The following fixes it:

diff --git a/src/background/background.cpp b/src/background/background.cpp
index f845447..998fb88 100644
--- a/src/background/background.cpp
+++ b/src/background/background.cpp
@@ -118,6 +118,7 @@ bool WayfireBackground::change_background(int timer)
 bool WayfireBackground::load_images_from_dir(std::string path)
 {
     wordexp_t exp;
+    exp = {};
 
     /* Expand path */
     wordexp(path.c_str(), &exp, 0);

It seems that exp is initialized with random garbage, and wordexp() does not change it if it encounters an error. I'm not sure if that is correct behavior though or if I should try to report this as a bug.

[soreau]

It seems that exp is initialized with random garbage, and wordexp() does not change it if it encounters an error. I'm not sure if that is correct behavior though or if I should try to report this as a bug.

I would say make a PR with your patch here, even if the bug is with wordexp, it would take awhile to get fixed in distro repos, if a fix is accepted.