window list causes 5~ CPU utilization when idle

[wayfirewm]

window list causes 5~ CPU utilization when idle

[damianatorrpm]

Related, gtk4 removed signal size allocate altogether:
https://developer.gnome.org/gtk4/stable/ch40s02.html "Adapt to GtkWidget’s size allocation changes"

[ammen99]

If you add a debug log inside the lamda (which resets wm struts) you will see that it gets called (when size is normal)
a few dozen times per second while you move the mouse over window-list.

Seems like we should cache the last requested size and recreate the wm struts only if the new size is different than the previous one.

[damianatorrpm]

I believe the resize signal (have to check if that's in gtk3, mentioned in the link) would fix this but I have to try it yet

[ammen99]

That would be even better indeed

[damianatorrpm]

btw, meanwhile I have found an easy fix for gtk3 instead of putting widgets in a scolled window put the whole panel_box in a scrolled view. Behaviour would be slightly different but no 5% cpu utilization

[ammen99]

Hey, that's a good idea, it would also solve the problem in the cases where the widgets themselves are too many. Do you have a PR which you can send? :)

[damianatorrpm]

My codebase is way too different and when I'm finished I will focus on PR'ing something for wayfire,
bug fixes where I can etc. I wanted to share my solution though :)

The only thing that's comprable is that it can take gtk widget into a box and uses the wf-shell for autohiding :)
(e.g I don't used preffered size for panel, but fixed)

But the changes are not many, remove scrolled_window from window list and wrap the panel box into a scrolled window.
additionally I find it better that the scollbars are always visible, although a problem there is that the scroll direction
is implicitly vertical when you are over the content, so gtk forces you to hover the scrollbar to hover. (for horizontal panels)

// TODO: vertical bug, button size is panel width and non overlay adds size of scrollbar
  if (panel->is_horizontal) 
    panel->scrolled_window.set_overlay_scrolling(FALSE);