Refactoring - split code logically intuitive separate related files

[StormeHawke]

Refactoring - split code logically intuitive separate related files

[RavenDT]

@t0cableguy The minification they are referring to I believe means eliminating all whitespace in order to reduce script size. This is an accepted practice for published libraries like jQuery.

Because WMEPH is downloaded once and run locally, there's no need to do that.

[RavenDT]

I was thinking the same thing; but, I personally, am not sure how that works with user scripts.

As an alternative, in the refactoring process, if we just simply reorganize the code into a better fashion, it would be way easier to maintain.

The way the code is written now:

// Globals

// GM/TM Header

// Main function
function () {
    // Declare variables
    // Array prototypes (for Firefox fix)

    // All function declarations, main code, all jumbled together and in no clear order.

The way we could/should write the code:

// Globals

// GM/TM Header

// Constants (like URLs to google sheets)

// Subroutine function declarations
// [ Pretty much all logic should be moved here in their own separate functions ]

// Main function
function() {
    // Only code for bootstraps and setting timeouts
}

[t0cableguy]

just FYI if we minify the code we will not be able to use GF to host the script, not that I'm pining to use it.

[StormeHawke]

I was thinking more on the level of minimal minification that just concats all the separate files together into a single published version

[mapomatic]

I think separate files would be ideal from a pure programming perspective, but am in the same boat with Raven that I don't know how to accomplish that with a script -- and better organization should accomplish some of the same goals.

[RavenDT]

It looks like we'll be doing some of this. I've found some code that really shouldn't be inside the main script.

We can host the files here on github as a part of the repo, and then just load them using @require or @resource.

[RavenDT]

We started doing this. Going to mark this as done.