Comments (7)
@t0cableguy The minification they are referring to I believe means eliminating all whitespace in order to reduce script size. This is an accepted practice for published libraries like jQuery.
Because WMEPH is downloaded once and run locally, there's no need to do that.
from wme-place-harmonizer.
I was thinking the same thing; but, I personally, am not sure how that works with user scripts.
As an alternative, in the refactoring process, if we just simply reorganize the code into a better fashion, it would be way easier to maintain.
The way the code is written now:
// Globals
// GM/TM Header
// Main function
function () {
// Declare variables
// Array prototypes (for Firefox fix)
// All function declarations, main code, all jumbled together and in no clear order.
The way we could/should write the code:
// Globals
// GM/TM Header
// Constants (like URLs to google sheets)
// Subroutine function declarations
// [ Pretty much all logic should be moved here in their own separate functions ]
// Main function
function() {
// Only code for bootstraps and setting timeouts
}
from wme-place-harmonizer.
just FYI if we minify the code we will not be able to use GF to host the script, not that I'm pining to use it.
from wme-place-harmonizer.
I was thinking more on the level of minimal minification that just concats all the separate files together into a single published version
from wme-place-harmonizer.
I think separate files would be ideal from a pure programming perspective, but am in the same boat with Raven that I don't know how to accomplish that with a script -- and better organization should accomplish some of the same goals.
from wme-place-harmonizer.
It looks like we'll be doing some of this. I've found some code that really shouldn't be inside the main script.
We can host the files here on github as a part of the repo, and then just load them using @require
or @resource
.
from wme-place-harmonizer.
We started doing this. Going to mark this as done.
from wme-place-harmonizer.
Related Issues (20)
- Add service buttons for PLA's
- Autofill EV charging station payment types based on network HOT 1
- Add button to set standard EV Charging Station payment types HOT 1
- Fix green highlighting of updated fields
- Handle whitespaces in ph_speccase column
- Hours not parsing correctly in some cases where Sunday listed first HOT 2
- Add 24/7 button by the Hours section in the banner
- Make Tesla station type clickable HOT 2
- Add buttons for EVCS price field
- Allow deleting hours from banner
- Hours parsing error
- WMEPH complains sea/lake/ponds without names should be points, not areas HOT 2
- Bug when adding a new RPP while previous RPP is selected
- Category not updating on 7-Eleven (investigate)
- Hours parser not working for noon-midnight
- Script does not load due to use of @include HOT 1
- Suggestion: Strip "Hours:" and "Day(s) of the week:" when parsing hours
- Nudge button broken HOT 1
- Suggestion: strip Google Analytics from URL HOT 4
- Edge Issue HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wme-place-harmonizer.