Faraday gem breaks SSL connections on 0.6.1

[wearefarmgeek]

Faraday gem breaks SSL connections on 0.6.1

[johnhamelink]

Hey there, thanks for this detailed report! It's a holiday today here in Scotland so I'm planning on sorting all of the outstanding issues and releasing a new version today.

Thanks for using diplomat!
JH

[johnhamelink]

For reference, here's a comparison between 0.5.1 and 0.6.1:

c77985b...6171639

[guymaliar]

I looked at the comparison when I was investigating but I didn't thoroughly go over it, it seems that this might be the first place to look for changes, diplomat/lib/diplomat/rest_client.rb

[johnhamelink]

@guymaliar have you tried adding the ca_path to the faraday config? Check here under Ubuntu: https://github.com/lostisland/faraday/wiki/Setting-up-SSL-certificates

If that doesn't work, can you try removing "faraday.adapter Faraday.default_adapter" and running again? I'd do that but I'm on a mac right now with limited battery 😄

[guymaliar]

👍 I will have a go at both, will take me an hour or so though

[johnhamelink]

Cool, let me know how it goes either way - we'll get to the bottom of it 😄

[guymaliar]

@johnhamelink actually it was faster than I thought,
I commented out the faraday.adapter Faraday.default_adapter and it now returns /src/research/diplomat/gem/lib/diplomat/kv.rb:60:inget': status (Diplomat::UnknownStatus)`

This looks the error message that should be returned.

Thoughts?

[johnhamelink]

Hey @guymaliar - how did you get on before? Did you manage to find a fix?

[guymaliar]

Hey guy, sorry I was on vacation, yes I managed to find a fix, removing the faraday.adapter Faraday.default_adapter solved it.
I will send a pull request this week.

[johnhamelink]

Thanks @guymaliar 😄

[johnhamelink]

@guymaliar I'm going to close this ticket for now, if you get time to submit a PR, please do 😄

[guymaliar]

I will do it as soon as possible

—
Sent from Mailbox

On Sun, May 24, 2015 at 5:24 PM, John Hamelink [email protected]
wrote:

@guymaliar I'm going to close this ticket for now, if you get time to submit a PR, please do 😄

Reply to this email directly or view it on GitHub:
#27 (comment)