Giter Site home page Giter Site logo

Comments (6)

johnhamelink avatar johnhamelink commented on May 24, 2024

Agreed. I think an initializer style config would work well (http://robots.thoughtbot.com/mygem-configure-block), what do you think?

from diplomat.

ross-w avatar ross-w commented on May 24, 2024

Yep, that seems like the most sensible option for setting that up. Perhaps the same mechanism could be used for configuring the consul URL (noted on your TODO list) at the same time?

from diplomat.

johnhamelink avatar johnhamelink commented on May 24, 2024

Yup Good shout. I edited your issue to create a todo list for us 😄 I'm away to a conference all day today, but I'll try to take a look at this tonight.

Worth noting we should also assume all values by default to try to keep the gem as wire compatible with previous versions as possible!

from diplomat.

johnhamelink avatar johnhamelink commented on May 24, 2024

@ross-w I've had a go at implementing this as it became something important to @WeAreFarmGeek today.

1a7680b

It's unit tested and also tested with cucumber (requiring consul to be running), so it seems to be wire compatible with the previous version. I'm pushing a release now. Let me know what you think of it!

from diplomat.

ross-w avatar ross-w commented on May 24, 2024

Hi @johnhamelink thanks so much for that, works perfectly! Sorry I didn't get a chance to jump in with the coding this time, either.

Thanks again for the gem, it's even more useful for us now than before :)

from diplomat.

johnhamelink avatar johnhamelink commented on May 24, 2024

Glad to hear it, that's what I'm aiming for :)

from diplomat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.