Giter Site home page Giter Site logo

Comments (5)

benochr avatar benochr commented on August 17, 2024

Same problem here.

It seems that the output of html-loader changed in v1.0.0.

In version 0.5.5 the output looked like this:
module.exports = "... html ...";

In version 1.1.0 the output has changed to:

// Module
var code = "... html ...";
// Exports
module.exports = code;

from ngtemplate-loader.

benochr avatar benochr commented on August 17, 2024

Because of this change following code is no longer working as intended.

if (content.match(/^module\.exports/)) {
        var firstQuote = findQuote(content, false);
        var secondQuote = findQuote(content, true);
        html = content.substr(firstQuote, secondQuote - firstQuote + 1);
} else {
        html = content;
}

from ngtemplate-loader.

peterpoe avatar peterpoe commented on August 17, 2024

Hey I have provided an alternative fix here #87 that adds compatibility with file-loader for stuff like <img src="..."> replacement

from ngtemplate-loader.

cb-eli avatar cb-eli commented on August 17, 2024

@WearyMonkey can you merge, please? :)

from ngtemplate-loader.

WearyMonkey avatar WearyMonkey commented on August 17, 2024

Sorry for the delay, I've released it now.

from ngtemplate-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.