Video/Image always square. Any settings that could support width/height ratio tuning?

[webarkit]

Video/Image always square. Any settings that could support width/height ratio tuning?

[kalwalt]

This toolkit is so awesome that I almost had no trouble to set things up :)

During my test, ideally we would love to cover the whole marker with media content. While under default setting, the height and width are almost identical even it is a 1024x480 or 360x720 media file.

@kalwalt Any input or code modification guidance would be appreciated. Thanks in advance!!

Also some heads up: the video is blacked out in iOS 14.6 (which never happened in previous iOS releases). I guess it is relevant with new privacy rules introduced.

@ronaldyang Sorry for the delay! I have limited time until the end of september.
About the width and the height: i think you are refering to the addVideo function, Now with the the new version is outside ARnft and is in a separate repository https://github.com/webarkit/ARnft-threejs see here

ARnft-threejs/src/markermedia/NFTaddTJS.ts

Lines 53 to 68 in a36b503

	public addVideo (id: string, scale: number) {
	const root = this.root
	const ARVideo: HTMLVideoElement = document.getElementById(id) as HTMLVideoElement;
	const texture = new VideoTexture(ARVideo as HTMLVideoElement)
	const mat = new MeshStandardMaterial({ color: 0xbbbbff, map: texture })
	ARVideo.play()
	const planeGeom = new PlaneGeometry(1, 1, 1, 1)
	const plane = new Mesh(planeGeom, mat)
	plane.scale.set(scale, scale, scale)
	document.addEventListener('getNFTData', (ev: any) => {
	var msg = ev.detail
	plane.position.y = (msg.height / msg.dpi * 2.54 * 10) / 2.0
	plane.position.x = (msg.width / msg.dpi * 2.54 * 10) / 2.0
	})
	this.root.add(plane)
	}

For sure need an improvement, there is also some issues with Firefox and other browsers #8 Maybe you have an idea?

[kalwalt]

@ronaldyang this was done in PR #26 let me know if it is ok for you. Closing this, open another issue if you have troubles.