Randomize LC_ALL in CI?

[SoniEx2]

Randomize LC_ALL in CI?

[sbc100]

What kind of failures are you hoping to catch?

[SoniEx2]

the kind of failures that happen when someone tries to parse localizable strings ^^

[keithw]

WABT itself never calls setlocale(), so afaik there's no way that the LC_ALL environment variable can affect the behavior of any of the executables or tests.

I also don't think libwabt ever calls a locale-sensitive function (so even if it's linked with an application that has called setlocale(), I don't think libwabt's behavior will be affected), but I'm not 100% sure about this. If we find a counterexample, my view would be that we should probably just remove it...

[SoniEx2]

yeah, but you never know whether you're accidentally relying on localizable strings in e.g. shell scripts.

randomizing LC_ALL should make it obvious if you are.

it also prevents future code from doing this too.

[sbc100]

Have we had reports of such issues in wabt?

[SoniEx2]

Not that we know of, no. And it should stay that way.

[keithw]

Closing for now -- I don't think we have consensus that the benefit here would be worth it.