Provide a field with the actual class name of a default exported class

[webcomponents]

Provide a field with the actual class name of a default exported class

[thepassle]

This was corrected in @custom-elements-manifest/analyzer v0.4.7 👍

[thepassle]

I've ran into the situation myself a couple of times as well, where I need to find a class that is exported as default. I do think this is currently a limitation of the schema, and we should improve on this

[Matsuuu]

Example case:

https://custom-elements-manifest.netlify.app/?source=CmV4cG9ydCBkZWZhdWx0IGNsYXNzIE15RWxlbWVudCBleHRlbmRzIEhUTUxFbGVtZW50IHt9CgpleHBvcnQgY2xhc3MgTXlFeHRlbmRpbmdFbGVtZW50IGV4dGVuZHMgTXlFbGVtZW50IHt9CmN1c3RvbUVsZW1lbnRzLmRlZmluZSgibXktZXh0ZW5kaW5nLWVsZW1lbnQiLCBNeUV4dGVuZGluZ0VsZW1lbnQpOw%3D%3D&library=vanilla

If we have a MyElement class we want to extend our element from, and then we want to backtrack from MyExtendingElement's "superclass.name" to find the declarations of it, we can't find it with the current information, as the name "MyElement" is not present in the declaration at all.

"declarations": [
        {
          "kind": "class",
          "description": "",
          "name": "default",
          "superclass": {
            "name": "HTMLElement"
          },
          "customElement": true
        },
        {
          "kind": "class",
          "description": "",
          "name": "MyExtendingElement",
          "superclass": {
            "name": "MyElement",
            "module": "src/my-element.js"
          },
          "tagName": "my-extending-element",
          "customElement": true
        }
      ],

[justinfagnani]

The way this should work is the same for any export that renames the item: the export has a name that's independent of the declaration name.

export default class MyElement {}

should result in an export named "default" and a reference to a class declaration named "MyElement".

Same with a rename:

class MyElementImpl {}
export {MyElementImpl as MyElement}

should result in an export named "MyElement" and a reference to a class declaration named "MyElementImpl".

From the playground it looks like the analyzer is getting this wrong.

This:

      "declarations": [
        {
          "kind": "class",
          "description": "",
          "name": "default",
          "superclass": {
            "name": "HTMLElement"
          },
          "customElement": true
        },

Should be:

      "declarations": [
        {
          "kind": "class",
          "description": "",
          "name": "MyElement",
          "superclass": {
            "name": "HTMLElement"
          },
          "customElement": true
        },

iow, a declaration should never have the name "default", unless someone actually named a class/function/variable that.

[justinfagnani]

Looks like this is being fixed in the Open WC analyzer. Closing here.