Comments (5)
I am using Typescript. And I had to use the following constructor to make it work.
constructor() {
return super();
}
from custom-elements.
I'm confused about what the upgrade for procedurally created elements refers to:
The current standard cannot possibly be polifilled "1:1" with vanilla JavaScript because procedurally created instances need an upgrade.
As far as I know, the main problem with CE v1 and polyfills is that you can't actually write a definition that doesn't use ES2015 that also works with a native implementation. Specifically, to construct a native custom element, you must either write it with class syntax and call super();
or use Reflect.construct
and pass new.target
- both of which are syntax errors in ES5.
Is this demo something like what you were asking about in the original question: http://jsbin.com/tapoqam/1/edit?html,output ?
from custom-elements.
@bicknellr It means that the instance of your element will go from instanceof HTMLUnknownElement
to instanceof YourCustomElement
magically, and your reference to it in your code (and in the DOM) will be the same reference. This magic happens on the native (C/C++) side of the engine, not really polyfillable.
from custom-elements.
@bicknellr Your example works fine because (I believe?) the polyfill just detects and uses the native implementation. But if you add transpiling (es6+ -> es5) then you run into the issues having to ironically use Reflect.construct
, etc, even though it isn't es5, because it needs to work when the polyfill detects the native implementation. Transpilation should work fine in a 100% es5 poyfill I think (just guessing, haven't tried yet).
from custom-elements.
README has some caveats for classes with es5 transpilation, this likely should have been closed when that was added.
from custom-elements.
Related Issues (20)
- Node.append() should be monkeypatched by custom-elements/src/Patch/Node.js HOT 2
- Use webcomponents-loader in webpack HOT 2
- Native ES6 classes do not work when the native-shim is in use. HOT 7
- Transpiling CEs to ES5 and loading them correctly HOT 1
- Object doesn't support property or method ... HOT 1
- Add support for `customElements.upgrade`.
- Constructor called twice in some cases HOT 2
- Duplicate declaration exception differs from original HOT 1
- CE polyfill is incompatible with babelHelpers class adapter HOT 4
- Modifying DOM in connectedCallback leads to wrong callback order for children. HOT 1
- No callbacks when using range.insertNode HOT 1
- Compiled version of custom-elements.min.js in latest version 1.1.2 does not exist in npm HOT 2
- Question: why use __ce_shadowRoot instead of shadowRoot HOT 7
- Error compiling m-datepicker HOT 1
- IE11/Edge errors SCRIPT28 and SCRIPT2343 (es5) HOT 2
- appreciate your feedback for custom element diagram HOT 7
- Can this polyfill be considered dead? HOT 2
- A browser extension overwrites HTMLElement.prototype.appendChild HOT 1
- Setting textContent to `null` or `undefined` incorrectly creates text with the string `null` or `undefined`
- Some errors thrown during define are squelched
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from custom-elements.