[v1] consistent constructor

[webcomponents]

[v1] consistent constructor

[notwaldorf]

From @treshugart on August 15, 2016 0:22

I think the issue you're experiencing is that extends hasn't been implemented yet: https://github.com/webcomponents/webcomponentsjs/blob/v1/src/CustomElements/v1/CustomElements.js#L143

Subclassing HTMLAnchorElement should still work, though: https://github.com/webcomponents/webcomponentsjs/blob/v1/src/CustomElements/v1/CustomElements.js#L477

I know there's currently still unresolved contention about is and extends as WebKit is pretty hard-fast about not implementing it, so I'm not sure what the polyfill will work to support. I assume it's on the roadmap as it's still in the custom element spec.

[notwaldorf]

From @WebReflection on August 15, 2016 8:16

I've probably badly explained the issue. Beside extends and is definition variant, the following code will fail (and every other code that has not been patched like HTMLElement in here)

// create the class
class MyA extends HTMLAnchorElement {}

// define its name
customElements.define('my-a', MyA);

// and fail ...
document.body.appendChild(new MyA);

If I do the same with the patched HTMLElement the result is the expected one.

class MyElement extends HTMLElement {}
customElements.define('my-el', MyElement);
document.body.appendChild(new MyElement); // OK

Since I see that also document.createElement is patched, together with other methods, I wonder if the usage of new CustomElement will be discouraged in this polyfill or if in the future every native constructor will be patched like it's done already for the HTMLELement one.

[notwaldorf]

From @treshugart on August 15, 2016 14:4

@WebReflection Ahh, ok, that makes perfect sense.

I just submitted a preliminary PR (#596) adding support for customised built-ins. It definitely needs more testing and some cleanup, but it's something that can hopefully get this started. I'm not sure the plans @justinfagnani has here, though. Would be good to get his thoughts, too.

[notwaldorf]

From @justinfagnani on August 30, 2016 7:15

Extending other built-ins besides HTMLElement (even without is=) fails in Chrome's native implementation right now, because only HTMLElement has a callable constructor. I need to see what's happening there before moving on this...

[WebReflection]

so I'm not sure what the polyfill will work to support.

Safari and WebKit nightly are patched to work as expected extending native builtins and using is="attribute" and extends

I assume it's on the roadmap as it's still in the custom element spec.

Yes, my polyfill follows the specs.

[WebReflection]

P.S. Thank You !!!