Comments (8)
thomaszbz
commented on June 15, 2024
current status as of bd807f1 :
/usr/bin/phpcs --standard=PSR2 --report=summary --report-width=120 .
PHP CODE SNIFFER REPORT SUMMARY
-----------------------------------------------------------------------------------------------
FILE ERRORS WARNINGS
-----------------------------------------------------------------------------------------------
metaseo/Classes/Backend/Ajax/PageAjax.php 63 3
metaseo/Classes/Backend/Ajax/SitemapAjax.php 16 1
metaseo/Classes/Backend/Ajax/AbstractAjax.php 21 1
metaseo/Classes/Backend/Module/AbstractStandardModule.php 2 0
metaseo/Classes/Backend/Module/AbstractTreeModule.php 2 0
metaseo/Classes/Backend/Module/AbstractModule.php 13 0
metaseo/Classes/Backend/Validator/ValidatorImport.php 3 0
metaseo/Classes/Backend/Validator/FloatValidator.php 5 0
metaseo/Classes/Command/MetaseoCommandController.php 15 0
metaseo/Classes/Controller/BackendControlCenterController.php 10 3
metaseo/Classes/Controller/BackendPageSeoController.php 17 8
metaseo/Classes/Controller/BackendRootSettingsController.php 10 3
metaseo/Classes/Controller/BackendSitemapController.php 25 6
metaseo/Classes/Hook/ClearCacheHook.php 4 0
metaseo/Classes/Hook/Extension/NewsExtension.php 3 0
metaseo/Classes/Hook/Extension/TtnewsExtension.php 4 0
metaseo/Classes/Hook/HttpHook.php 4 0
metaseo/Classes/Hook/SitemapIndexHook.php 49 0
metaseo/Classes/Hook/TCA/RobotsTxtDefault.php 4 5
metaseo/Classes/Page/Part/AbstractPart.php 4 0
metaseo/Classes/Page/Part/FooterPart.php 29 2
metaseo/Classes/Page/Part/PagetitlePart.php 19 1
metaseo/Classes/Page/Part/MetatagPart.php 54 31
metaseo/Classes/Page/RobotsTxtPage.php 10 2
metaseo/Classes/Page/AbstractPage.php 9 1
metaseo/Classes/Page/SitemapTxtPage.php 7 0
metaseo/Classes/Page/SitemapXmlPage.php 7 0
metaseo/Classes/Scheduler/Task/GarbageCollectionTask.php 4 0
metaseo/Classes/Scheduler/Task/AbstractSitemapTask.php 13 0
metaseo/Classes/Scheduler/Task/AbstractTask.php 30 0
metaseo/Classes/Scheduler/Task/SitemapTxtTask.php 6 0
metaseo/Classes/Scheduler/Task/SitemapXmlTask.php 8 0
metaseo/Classes/Sitemap/Generator/AbstractGenerator.php 10 0
metaseo/Classes/Sitemap/Generator/TxtGenerator.php 4 0
metaseo/Classes/Sitemap/Generator/XmlGenerator.php 8 3
metaseo/Classes/Utility/BackendUtility.php 8 0
metaseo/Classes/Utility/CacheUtility.php 29 0
metaseo/Classes/Utility/ConsoleUtility.php 118 0
metaseo/Classes/Utility/DatabaseUtility.php 73 1
metaseo/Classes/Utility/FrontendUtility.php 59 1
metaseo/Classes/Utility/GeneralUtility.php 54 1
metaseo/Classes/Utility/RootPageUtility.php 7 0
metaseo/Classes/Utility/SitemapUtility.php 20 1
metaseo/Classes/Connector.php 19 0
metaseo/Configuration/TCA/Overrides/pages.php 218 3
metaseo/Configuration/TCA/Overrides/pages_language_overlay.php 91 3
metaseo/Configuration/TCA/tx_metaseo_setting_root.php 130 9
metaseo/Resources/Public/Backend/Css/Default.css 20 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.metaeditor.js 12 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.overview.js 30 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.sitemap.js 6 0
metaseo/Resources/Public/Frontend/JavaScript/GoogleAnalyticsTrackDownload.js 42 0
metaseo/class.ext_update.php 26 0
metaseo/ext_emconf.php 36 2
metaseo/ext_localconf.php 0 18
metaseo/ext_tables.php 4 0
-----------------------------------------------------------------------------------------------
A TOTAL OF 1494 ERROR(S) AND 109 WARNING(S) WERE FOUND IN 56 FILE(S)
-----------------------------------------------------------------------------------------------
from typo3-metaseo.
thomaszbz
commented on June 15, 2024
Applying
php-cs-fixer fix /home/thomas/75_phpstorm/metaseo/ --level=psr2
looks promising in d0f1767 :
/usr/bin/phpcs --standard=PSR2 --report=summary --report-width=120 .
PHP CODE SNIFFER REPORT SUMMARY
-----------------------------------------------------------------------------------------------
FILE ERRORS WARNINGS
-----------------------------------------------------------------------------------------------
metaseo/Classes/Backend/Ajax/PageAjax.php 8 3
metaseo/Classes/Backend/Ajax/SitemapAjax.php 0 1
metaseo/Classes/Backend/Ajax/AbstractAjax.php 1 1
metaseo/Classes/Backend/Validator/ValidatorImport.php 2 0
metaseo/Classes/Controller/BackendControlCenterController.php 1 3
metaseo/Classes/Controller/BackendPageSeoController.php 3 8
metaseo/Classes/Controller/BackendRootSettingsController.php 1 3
metaseo/Classes/Controller/BackendSitemapController.php 3 6
metaseo/Classes/Hook/SitemapIndexHook.php 2 0
metaseo/Classes/Hook/TCA/RobotsTxtDefault.php 0 5
metaseo/Classes/Page/Part/FooterPart.php 7 2
metaseo/Classes/Page/Part/PagetitlePart.php 1 1
metaseo/Classes/Page/Part/MetatagPart.php 0 31
metaseo/Classes/Page/RobotsTxtPage.php 0 2
metaseo/Classes/Page/AbstractPage.php 0 1
metaseo/Classes/Scheduler/Task/AbstractSitemapTask.php 1 0
metaseo/Classes/Scheduler/Task/SitemapTxtTask.php 1 0
metaseo/Classes/Scheduler/Task/SitemapXmlTask.php 2 0
metaseo/Classes/Sitemap/Generator/XmlGenerator.php 0 3
metaseo/Classes/Utility/DatabaseUtility.php 0 1
metaseo/Classes/Utility/FrontendUtility.php 0 1
metaseo/Classes/Utility/GeneralUtility.php 0 1
metaseo/Classes/Utility/SitemapUtility.php 0 1
metaseo/Configuration/TCA/Overrides/pages.php 0 11
metaseo/Configuration/TCA/Overrides/pages_language_overlay.php 0 3
metaseo/Configuration/TCA/tx_metaseo_setting_root.php 0 14
metaseo/Resources/Public/Backend/Css/Default.css 20 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.metaeditor.js 12 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.overview.js 30 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.sitemap.js 6 0
metaseo/Resources/Public/Frontend/JavaScript/GoogleAnalyticsTrackDownload.js 42 0
metaseo/class.ext_update.php 3 0
metaseo/ext_emconf.php 0 2
metaseo/ext_localconf.php 0 18
-----------------------------------------------------------------------------------------------
A TOTAL OF 146 ERROR(S) AND 122 WARNING(S) WERE FOUND IN 34 FILE(S)
-----------------------------------------------------------------------------------------------
As far as I can see there's just syntax changes without change in behaviour.
from typo3-metaseo.
thomaszbz
commented on June 15, 2024
Class
tx_metaseo_backend_validation_float
is deprecated since at least 2014-08-31. I also found no usage of the class. Can I drop the class?
from typo3-metaseo.
thomaszbz
commented on June 15, 2024
There's been a lot of lines with too many characters. Therefore, I tried removing fully qualified names in c41a342 :
/usr/bin/phpcs --standard=PSR2 --report=summary --report-width=120 .
PHP CODE SNIFFER REPORT SUMMARY
-----------------------------------------------------------------------------------------------
FILE ERRORS WARNINGS
-----------------------------------------------------------------------------------------------
metaseo/Classes/Backend/Ajax/AbstractAjax.php 1 0
metaseo/Classes/Backend/Ajax/PageAjax.php 8 2
metaseo/Classes/Backend/Validator/ValidatorImport.php 2 0
metaseo/Classes/Controller/BackendRootSettingsController.php 1 1
metaseo/Classes/Controller/BackendPageSeoController.php 3 7
metaseo/Classes/Controller/BackendSitemapController.php 3 3
metaseo/Classes/Controller/BackendControlCenterController.php 1 1
metaseo/Classes/Hook/TCA/RobotsTxtDefault.php 0 4
metaseo/Classes/Hook/SitemapIndexHook.php 2 0
metaseo/Classes/Page/Part/FooterPart.php 7 2
metaseo/Classes/Page/Part/PagetitlePart.php 1 1
metaseo/Classes/Page/Part/MetatagPart.php 0 31
metaseo/Classes/Page/RobotsTxtPage.php 0 1
metaseo/Classes/Scheduler/Task/SitemapTxtTask.php 1 0
metaseo/Classes/Scheduler/Task/SitemapXmlTask.php 2 0
metaseo/Classes/Scheduler/Task/AbstractSitemapTask.php 1 0
metaseo/Classes/Sitemap/Generator/XmlGenerator.php 0 2
metaseo/Classes/Utility/DatabaseUtility.php 0 1
metaseo/Classes/Utility/SitemapUtility.php 0 1
metaseo/Configuration/TCA/Overrides/pages_language_overlay.php 0 3
metaseo/Configuration/TCA/Overrides/pages.php 0 11
metaseo/Configuration/TCA/tx_metaseo_setting_root.php 0 14
metaseo/Resources/Public/Backend/Css/Default.css 20 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.metaeditor.js 12 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.overview.js 30 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.sitemap.js 6 0
metaseo/Resources/Public/Frontend/JavaScript/GoogleAnalyticsTrackDownload.js 42 0
metaseo/ext_localconf.php 0 18
metaseo/ext_emconf.php 0 2
metaseo/class.ext_update.php 3 0
-----------------------------------------------------------------------------------------------
A TOTAL OF 146 ERROR(S) AND 105 WARNING(S) WERE FOUND IN 30 FILE(S)
-----------------------------------------------------------------------------------------------
ok, this was good for nothing in terms of coding style, thus still making the code much cleaner.
I used IDE support for that, still solving conflicts in case classes with same name had to be imported. That said, it's hopefully just a syntax change with no change in behaviour (as long as there's no strange namespace mismatch in typo3 and other extensions).
from typo3-metaseo.
thomaszbz
commented on June 15, 2024
Now, that was a good one in 1bd547d , fixing warnings mainly
/usr/bin/phpcs --standard=PSR2 --report=summary --report-width=120 .
PHP CODE SNIFFER REPORT SUMMARY
-----------------------------------------------------------------------------------------------
FILE ERRORS WARNINGS
-----------------------------------------------------------------------------------------------
metaseo/Classes/Backend/Ajax/AbstractAjax.php 1 0
metaseo/Classes/Backend/Ajax/PageAjax.php 8 1
metaseo/Classes/Backend/Validator/ValidatorImport.php 2 0
metaseo/Classes/Controller/BackendControlCenterController.php 1 0
metaseo/Classes/Controller/BackendPageSeoController.php 3 0
metaseo/Classes/Controller/BackendSitemapController.php 9 0
metaseo/Classes/Controller/BackendRootSettingsController.php 1 0
metaseo/Classes/Hook/SitemapIndexHook.php 2 0
metaseo/Classes/Page/Part/PagetitlePart.php 1 0
metaseo/Classes/Page/Part/FooterPart.php 2 0
metaseo/Classes/Scheduler/Task/SitemapTxtTask.php 1 0
metaseo/Classes/Scheduler/Task/SitemapXmlTask.php 2 0
metaseo/Classes/Scheduler/Task/AbstractSitemapTask.php 1 0
metaseo/Classes/Utility/DatabaseUtility.php 0 1
metaseo/Configuration/TCA/Overrides/pages_language_overlay.php 0 3
metaseo/Configuration/TCA/Overrides/pages.php 0 11
metaseo/Configuration/TCA/tx_metaseo_setting_root.php 0 14
metaseo/Resources/Public/Backend/Css/Default.css 20 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.metaeditor.js 12 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.overview.js 30 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.sitemap.js 6 0
metaseo/Resources/Public/Frontend/JavaScript/GoogleAnalyticsTrackDownload.js 42 0
metaseo/ext_localconf.php 0 18
metaseo/ext_emconf.php 0 2
metaseo/class.ext_update.php 3 0
-----------------------------------------------------------------------------------------------
A TOTAL OF 147 ERROR(S) AND 50 WARNING(S) WERE FOUND IN 25 FILE(S)
-----------------------------------------------------------------------------------------------
from typo3-metaseo.
thomaszbz
commented on June 15, 2024
Now, that was a good one in 6b57c1e
/usr/bin/phpcs --standard=PSR2 --report=summary --report-width=120 .
PHP CODE SNIFFER REPORT SUMMARY
-----------------------------------------------------------------------------------------------
FILE ERRORS WARNINGS
-----------------------------------------------------------------------------------------------
metaseo/Classes/Backend/Validator/ValidatorImport.php 2 0
metaseo/Classes/Hook/SitemapIndexHook.php 2 0
metaseo/Classes/Page/Part/FooterPart.php 1 0
metaseo/Classes/Scheduler/Task/SitemapTxtTask.php 1 0
metaseo/Classes/Scheduler/Task/SitemapXmlTask.php 2 0
metaseo/Classes/Scheduler/Task/AbstractSitemapTask.php 1 0
metaseo/Resources/Public/Backend/Css/Default.css 20 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.metaeditor.js 12 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.overview.js 30 0
metaseo/Resources/Public/Backend/JavaScript/MetaSeo.sitemap.js 6 0
metaseo/Resources/Public/Frontend/JavaScript/GoogleAnalyticsTrackDownload.js 42 0
metaseo/class.ext_update.php 2 0
metaseo/ext_emconf.php 0 1
-----------------------------------------------------------------------------------------------
A TOTAL OF 121 ERROR(S) AND 1 WARNING(S) WERE FOUND IN 13 FILE(S)
-----------------------------------------------------------------------------------------------
All remaining issues in .php files cannot be fixed as they come from typo3 requirements.
from typo3-metaseo.
thomaszbz
commented on June 15, 2024
Also fixed most of the javascript issues in 2fa725e .
In terms of coding style the rest is required by typo3. There's still some files containing tabs in directories Documentation and Resources only.
Possible improvements:
- I think class tx_metaseo_backend_validation_float (ValidatorImport.php) can be deleted.
- PATH_site could be provided as PATH_SITE from a class in the Metaseo namespace.
.
/usr/bin/phpcs --standard=PSR2 --report=summary --report-width=120 .
PHP CODE SNIFFER REPORT SUMMARY
-----------------------------------------------------------------------------------------------
FILE ERRORS WARNINGS
-----------------------------------------------------------------------------------------------
metaseo/Classes/Backend/Validator/ValidatorImport.php 2 0
metaseo/Classes/Hook/SitemapIndexHook.php 2 0
metaseo/Classes/Page/Part/FooterPart.php 1 0
metaseo/Classes/Scheduler/Task/SitemapTxtTask.php 1 0
metaseo/Classes/Scheduler/Task/SitemapXmlTask.php 2 0
metaseo/Classes/Scheduler/Task/AbstractSitemapTask.php 1 0
metaseo/class.ext_update.php 2 0
metaseo/ext_emconf.php 0 1
-----------------------------------------------------------------------------------------------
A TOTAL OF 11 ERROR(S) AND 1 WARNING(S) WERE FOUND IN 8 FILE(S)
-----------------------------------------------------------------------------------------------
In detail:
/usr/bin/phpcs --standard=PSR2 --report-width=120 .
FILE: /home/thomas/75_phpstorm/metaseo/Classes/Backend/Validator/ValidatorImport.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
------------------------------------------------------------------------------------------------------------------------
35 | ERROR | Each class must be in a namespace of at least one level (a top-level vendor name)
35 | ERROR | Class name "tx_metaseo_backend_validation_float" is not in camel caps format
------------------------------------------------------------------------------------------------------------------------
Reason: file can be deleted
FILE: /home/thomas/75_phpstorm/metaseo/Classes/Hook/SitemapIndexHook.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
------------------------------------------------------------------------------------------------------------------------
252 | ERROR | Public method name "SitemapIndexHook::hook_indexContent" is not in camel caps format
273 | ERROR | Public method name "SitemapIndexHook::hook_linkParse" is not in camel caps format
------------------------------------------------------------------------------------------------------------------------
Reason: TYPO3 specific function names
FILE: /home/thomas/75_phpstorm/metaseo/Classes/Page/Part/FooterPart.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
------------------------------------------------------------------------------------------------------------------------
180 | ERROR | Constants must be uppercase; expected PATH_SITE but found PATH_site
------------------------------------------------------------------------------------------------------------------------
Reason: TYPO3 specific constant
FILE: /home/thomas/75_phpstorm/metaseo/Classes/Scheduler/Task/SitemapTxtTask.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
------------------------------------------------------------------------------------------------------------------------
74 | ERROR | Constants must be uppercase; expected PATH_SITE but found PATH_site
------------------------------------------------------------------------------------------------------------------------
Reason: TYPO3 specific constant
FILE: /home/thomas/75_phpstorm/metaseo/Classes/Scheduler/Task/SitemapXmlTask.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
------------------------------------------------------------------------------------------------------------------------
84 | ERROR | Constants must be uppercase; expected PATH_SITE but found PATH_site
90 | ERROR | Constants must be uppercase; expected PATH_SITE but found PATH_site
------------------------------------------------------------------------------------------------------------------------
Reason: TYPO3 specific constant
FILE: /home/thomas/75_phpstorm/metaseo/Classes/Scheduler/Task/AbstractSitemapTask.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
------------------------------------------------------------------------------------------------------------------------
91 | ERROR | Constants must be uppercase; expected PATH_SITE but found PATH_site
------------------------------------------------------------------------------------------------------------------------
Reason: TYPO3 specific constant
FILE: /home/thomas/75_phpstorm/metaseo/class.ext_update.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
------------------------------------------------------------------------------------------------------------------------
36 | ERROR | Each class must be in a namespace of at least one level (a top-level vendor name)
36 | ERROR | Class name "ext_update" is not in camel caps format
------------------------------------------------------------------------------------------------------------------------
Reason: TYPO3 specific class name (?)
FILE: /home/thomas/75_phpstorm/metaseo/ext_emconf.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
------------------------------------------------------------------------------------------------------------------------
38 | WARNING | Line exceeds 120 characters; contains 1315 characters
------------------------------------------------------------------------------------------------------------------------
Reason: encoded/generated data
from typo3-metaseo.
thomaszbz
commented on June 15, 2024
In general I hope that all the changes for this ticket contain no change in behaviour. Most of what has changed is syntax-only.
Please review the changes in javascript files ( 2fa725e ) carefully before merging. I did not test them at all.
PR #38 for that. I think you need to merge it before touching anything else... ;)
from typo3-metaseo.
Related Issues (20)
- Ignore deleted entries from pages_language_overlay
- composer require webdevops/metaseo load mblaschke/metaseo
- Sitemap...Task uses wrong path to write sitemap_txt and sitemap_xml HOT 5
- Remove setting backPath and 7.6.x workaround
- No indexation for sitemap HOT 11
- Open Graph Image no Image cropping tool visible HOT 3
- Sitemap loc from HTTP to HTTPS HOT 1
- Add Google Analytics Opt-Out for GDPR
- Translation issue HOT 2
- Nasty edge case page_hash bug in sitemap creation
- SEO-Tab in Page Options at Translation
- Blacklist für Pages with Parameters HOT 1
- Configuration option missing to deactivate setting the title (e.g. respect TypoScript config.noPageTitle) HOT 2
- Caching of __CURRENT__ in GeneralUtility::$rootlineCache breaks Sitemap...Tasks HOT 1
- Announcements: Making MetaSEO compatible to TYPO3 9LTS HOT 3
- Backend module: Seo/Metatags not working with sys_language_uid != 0
- alternate metatags instead of canonical
- MetaSEO sitemap doesnt show all entries
- Avoid indexing of disabled Extbase records / pages
- Generated Sitemap contains URLs/Links from external sites
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typo3-metaseo.