Comments (3)
With the v2.0 we have introduced Messenger to handle the QueueItem to import, so the scope of the issue should be completed.
You should still keep the queue though and mark entries done in message handlers because there's no good way of checking for "item done" in messenger, especially once you start using an external queue system like RabbitMQ.
Obviously, without storing the imported items in the queue we can't display the status of the imports, but keeping the current queue only for this scope smell. I am thinking to add something like a new entity that will contain the identifier of the product and some other info like the Akeneo attributes used to populate the product. Another solution could be simply adding a column importedAt on the ProductVariant with the timestamp of the last import from Akeneo. Anyway, this will be done in another issue.
from syliusakeneoplugin.
I think that if we need this kind of logic maybe it's better to refactor the plugin to fully use/support Symfony's Messenger component for the whole queue handling.
@fabianaromagnoli @LucaGallinari @lruozzi9 what do you think?
from syliusakeneoplugin.
Because I really love the messenger and also it's implementation: Absolutely!
You should still keep the queue though and mark entries done in message handlers because there's no good way of checking for "item done" in messenger, especially once you start using an external queue system like RabbitMQ.
from syliusakeneoplugin.
Related Issues (20)
- Use PHP 8 syntax
- Extract downloadFile in a new service
- [BUG?] - Some attribute option labels are not initialized to null
- [BUG] - Do not add product translation entity for locale not used in any channels of the product HOT 1
- Dispatch custom Akeneo plugin events HOT 1
- Update docs
- Improve importing product feature test
- Clear files and code no more used
- Move ApiClientMock file and fixtures outside of Integration test dir, it is also used by Behat.
- [BUG] - Database error while creating products without name HOT 1
- [BUG] - Channel Pricing Value Handler does not check for channel scope
- Enable the admin to manually force import of all products, attribute options and product associations HOT 1
- Admin user mass product update button HOT 1
- Disable Product accordingly to product Variants Status
- A non-UTF8 char has to trigger an alert during the import HOT 1
- Use Akeneo Events API
- Fix roave BC check
- Use new Symfony bundle directory structure HOT 1
- [BUG] - Import Akeneo boolean attributes in Sylius select attributes
- [BUG?] - Variant images not removed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from syliusakeneoplugin.