Giter Site home page Giter Site logo

Comments (3)

lruozzi9 avatar lruozzi9 commented on May 13, 2024 1

With the v2.0 we have introduced Messenger to handle the QueueItem to import, so the scope of the issue should be completed.

You should still keep the queue though and mark entries done in message handlers because there's no good way of checking for "item done" in messenger, especially once you start using an external queue system like RabbitMQ.

Obviously, without storing the imported items in the queue we can't display the status of the imports, but keeping the current queue only for this scope smell. I am thinking to add something like a new entity that will contain the identifier of the product and some other info like the Akeneo attributes used to populate the product. Another solution could be simply adding a column importedAt on the ProductVariant with the timestamp of the last import from Akeneo. Anyway, this will be done in another issue.

from syliusakeneoplugin.

mmenozzi avatar mmenozzi commented on May 13, 2024

I think that if we need this kind of logic maybe it's better to refactor the plugin to fully use/support Symfony's Messenger component for the whole queue handling.

@fabianaromagnoli @LucaGallinari @lruozzi9 what do you think?

from syliusakeneoplugin.

aleho avatar aleho commented on May 13, 2024

Because I really love the messenger and also it's implementation: Absolutely!

You should still keep the queue though and mark entries done in message handlers because there's no good way of checking for "item done" in messenger, especially once you start using an external queue system like RabbitMQ.

from syliusakeneoplugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.