Giter Site home page Giter Site logo

Comments (14)

sudo-suhas avatar sudo-suhas commented on May 30, 2024 1

@MoOx I would like to work on this. Could you please help me figure out the approach?

from eslint-loader.

ricardogobbosouza avatar ricardogobbosouza commented on May 30, 2024 1

Use nodemon for this.
Ex: nodemon --watch .eslintrc.js --exec webpack

from eslint-loader.

frontsideair avatar frontsideair commented on May 30, 2024

I'd like to see that too.

from eslint-loader.

MoOx avatar MoOx commented on May 30, 2024

PR are always welcome

from eslint-loader.

slightlytyler avatar slightlytyler commented on May 30, 2024

Have also run into an issue where I need similar functionality to accommodate https://github.com/apollographql/eslint-plugin-graphql. In my case I need to force eslint-loader to reload .eslintrc on every build. I see #151 and am wondering which of the cases described in this issue are satisfied by it. If my case is not covered I'll gladly contribute to that PR or another

from eslint-loader.

peternewnham avatar peternewnham commented on May 30, 2024

#151 still requires webpack to be restarted when changes are made to the rules so doesn't address this issue.

It also needs to be considered that there could be multiple .eslintrc files located anywhere in the project (see #123 and configFile option) and rules could also be applied directly to the eslint-loader options.

from eslint-loader.

MoOx avatar MoOx commented on May 30, 2024

I guess you should somehow watch for the file being used, and reload it in memory. Nothing is made to support this so you will need to handle this from scratch I guess.

from eslint-loader.

sudo-suhas avatar sudo-suhas commented on May 30, 2024

With eslint, there may not be just one eslint config file right? Would also need to invalidate cache when the config is modified.

from eslint-loader.

MoOx avatar MoOx commented on May 30, 2024

I guess so. Not an easy problem to solve and might open up to lots of bugs. Not sure if that's a good idea. If you work on your config, you should probably more play with eslint cli & files directly.

from eslint-loader.

sudo-suhas avatar sudo-suhas commented on May 30, 2024

This is what I have so far.

  • Get the eslint config files using globby and the pattern ["**/.eslintrc.*", "package.json", "!node_modules/**/*"].
  • Hash these files using hash-files and use it as part of the cacheIdentifier. However, this module is a little broken as the glob file resolution does not work correctly(hence the need for globby). Maybe I could use hasha instead.

However, this isn't enough as the eslint.CLIEngine seems to cache the config as well. How do you suggest I handle this?

from eslint-loader.

sudo-suhas avatar sudo-suhas commented on May 30, 2024

@MoOx Could you please help me out a little?

from eslint-loader.

langri-sha avatar langri-sha commented on May 30, 2024

Worth considering is that ESLint can also be configured via package.json. See Using Configuration Files.

from eslint-loader.

MoOx avatar MoOx commented on May 30, 2024

@sudo-suhas sorry I don't know where to start with this. The codebase is pretty small so you should try to understand it, check automated tests and see how you can tackle the problem. Feel free to ask questions if you need some detailed informations about a specific problem/ piece of code.

from eslint-loader.

DanielSchaffer avatar DanielSchaffer commented on May 30, 2024

@ricardogobbosouza that's not ideal - you lose all the benefits you get from running Webpack in watch mode

from eslint-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.