Giter Site home page Giter Site logo

Comments (8)

glenjamin avatar glenjamin commented on May 2, 2024

Yep, happy to do this.

I didn't realise even new IE didn't support EventSource!

As this is mostly a dev tool, I think I'll just pull in a polyfill

from webpack-hot-middleware.

glenjamin avatar glenjamin commented on May 2, 2024

Will take a PR, or add something myself soonish.

from webpack-hot-middleware.

glenjamin avatar glenjamin commented on May 2, 2024

I've added this in 94da926 - can you confirm it's fixed @insin and i'll cut a release. (Don't have easy access to IE right now)

from webpack-hot-middleware.

glenjamin avatar glenjamin commented on May 2, 2024

Released as v2.0.1

from webpack-hot-middleware.

glenjamin avatar glenjamin commented on May 2, 2024

Had a few reports of issues with this, so have deprecated v2.0.1 and released v2.0.2 which removes the polyfill (dfb7efb).

I'd like to bring this back in, but need to iron out the kinks

  • Don't rely on req.path - this is an express-only feature. Can use probably use req.uri and substring (#16)
  • Ensure the polyfill works when bundled (#13)
  • Possibly don't include the polyfill, and just add a note to docs?

from webpack-hot-middleware.

insin avatar insin commented on May 2, 2024

Not picking a particular polyfill to depend on would save a bunch of hassle in the long run (their bugs become your bugs... and IE-only ones at that 😄).

Documenting the need for one also provides a chance to point out potential bundling gotchas, and again those won't be your bugs, but the user's.

from webpack-hot-middleware.

glenjamin avatar glenjamin commented on May 2, 2024

Added a troubleshooting guide that mentions this, and made sure querystring parameters are accepted.

Let me know if you think more is needed.

from webpack-hot-middleware.

glenjamin avatar glenjamin commented on May 2, 2024

querystring changes released in v2.2.0

from webpack-hot-middleware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.