mangled exports breaks with destructuring assignment of JSON imports

[ikydd-bbc]

mangled exports breaks with destructuring assignment of JSON imports

[ikydd-bbc]

Thank you for the issue, do you want to send a pr?

Unfortunately I have no experience working with webpack internals or the details of project goals, so while I might be curious and have a dig to see what's what I couldn't commit to trying to fix this.

[ahabhgk]

I think there is already have a warning for named export with JSON

webpack/lib/json/JsonParser.js

Lines 62 to 63 in 7090328

	buildMeta.defaultObject =
	typeof data === "object" ? "redirect-warn" : false;

What about disable named export with JSON in next major and when futureDefaults: true?

I will take a look and try to fix this bug in the next few days

[alexander-akait]

Thank you for the issue, do you want to send a pr?

[alexander-akait]

/cc @ahabhgk What do you think? I don't like named export with JSON at all, because it volates a spec - there is no named export with JSON files, only default (should we output a warning on it? with futureDefaults: true), maybe we should disable mangle at all for JSON modules?

[alexander-akait]

@ikydd-bbc Just intresting, why you used named export for JSON? Legacy code?

[alopix]

@alexander-akait
The use case shown is not really a named export from JSON though, is it?
It uses a default import and then destructures the already imported default.

import data from './data.json';

// this works ...
console.log(data.foo.bar)

// ...but this does not
const { bar } = data.foo;

[alexander-akait]

@alopix Oh, I see, my mistake, sometimes the eyes are wrong 😄 We will look at this soon