Comments (7)
What's your serverless configuration?
Does serverless-scriptable-plugin able to fire if you have disable other plugins?
from serverless-scriptable-plugin.
@weixu365 it "fires" now just fine.
It's just that it fires before the other plugin, when I want it to fire after.
The part that confuses me is that the other plugin uses after:deploy:deploy
And I've tried configuring serverless-scriptable-plugin
to both after:deploy:deploy
and after:deploy:finalize
and still can't get it to fire after.
from serverless-scriptable-plugin.
Did you tried to change the plugin order in serverless config file?
from serverless-scriptable-plugin.
Yes, serverless-scriptable-plugin
is the very last plugin in that list.
plugins:
- serverless-lambda-version
- serverless-stack-output
- serverless-webpack
- serverless-scriptable-plugin
from serverless-scriptable-plugin.
I wrote a test service to verify the behaviour, and found that the execute order is based on plugins order in serverless.yml file
The problem you got is different one, I think it should be a bug of serverless-stack-output. serverless-stack-output is using promise to get the stack output but DID NOT return the promise object which causes:
- Start to execute serverless-stack-output
- Start to execute serverless-scriptable-plugin
- Finished executing serverless-stack-output
It's simple to fix this issue in serverless-stack-output, just return the promise object in 'process' method. I think you can create an issue in that repo
from serverless-scriptable-plugin.
Here's the output with return in serverless-stack-output:
start to get stack output
Serverless: Stack Output saved to file: ./stack.yaml
running scripts in scriptable plugin
Running javascript file: test.js
and here's the output without return in serverless-stack-output:
start to get stack output
running scripts in scriptable plugin
Running javascript file: test.js
Serverless: Removing old service versions...
Serverless: Stack Output saved to file: ./stack.yaml
from serverless-scriptable-plugin.
@weixu365 Thanks so much for diving deep into this!
I already have a PR into serverless-stack-output. I'll just add this fix in as well.
Cheers,
D
from serverless-scriptable-plugin.
Related Issues (20)
- scripts should be given a callback to define when work is done HOT 4
- Dependency Dashboard
- how to run "npm install --arch=x64 --platform=linux sharp" before zip happen on Mac HOT 3
- require local files in script HOT 1
- Improve maintenance on npm website HOT 1
- Stacktrace to `runCommand` should not be printed when command fails HOT 3
- serverless deploy only function does not trigger command HOT 1
- How to reference serverless variables in bash script HOT 5
- Deprecated hook "after:deploy:createDeploymentArtifacts" on Serverless 1.41.1 HOT 2
- List of hooks HOT 3
- Issue running this plugin with docker HOT 2
- scripthooks Not working with separate yml file HOT 2
- [Question] serverless-scriptable vs serverless-offline HOT 2
- Exit code HOT 8
- Action Required: Fix Renovate Configuration
- Changing the content to template file before deployment HOT 3
- PR suggestion: command HOT 27
- Better name for runcmd HOT 10
- Serverless variables aren't being resolved anymore HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serverless-scriptable-plugin.