On destroy removes chart before vue transitions finish

[weizhenye]

On destroy removes chart before vue transitions finish

[weizhenye]

I think #10 is not a proper solution to solve it.

Suppose there is a transition with 1s and I set destroyDelay to 1s, someday I extend transition to 2s, then I have to change destroyDelay too, I think components should not coupled with its style.

In this situation, we may use <keep-alive> to solve it.

<keep-alive>
  <modal v-if="showModal" @close="showModal = false">
    <h3 slot="header">custom header</h3>
  </modal>
</keep-alive>

[ErwanLent]

Original build that shows problem: https://jsfiddle.net/mwLbw11k/355/
Modified build with empty onDestroy function: https://jsfiddle.net/2ejeq43y/2/

[weizhenye]

Remove beforeDestroy may cause memory leak, you can find it with Chrome DevTools, repeat show and hide Modal several times, click Profiles -> Take Heap Snapshot -> Take Snapshot, then find Detached DOM tree.

Maybe we should find other ways to fix it.

[weizhenye]

I tried to replace beforeDestroy with destroyed, but found that destroyed is also triggered before afterLeave, and it's intended behavior in 2.x.

[ErwanLent]

Okay, good to know. I'll play around with some possible solutions today.

[ErwanLent]

I've found a solution. chart.destroy() needs to be called for there to be no memory leak. However, if you wait a delay inside the beforeDestroy event, this.chart becomes null and you cannot call destroy() on it. Highcharts, however, saves all the charts globally in Highcharts.charts. If you store the chart id in beforeDestroy, wait a delay for a transition to finish, then call the destroy() function on the chart stored in the Highcharts.charts array, the problem is solved.

I've forked the repo and added a destroyDelay prop that gives the option of putting in a millisecond amount before the highcharts is destroyed. I've run the build process, forked the repo, and opened a pull request. Please feel free to change the prop name.

Fix can be played with here: https://jsfiddle.net/hpkoemtw/2/

[ErwanLent]

That solution works, thanks!