"Instance Bonanza" - add lots of instances

[well-typed]

"Instance Bonanza" - add lots of instances

[phadej]

http://hackage.haskell.org/package/binary-orphans (shameless plug) is a good list of inspiration what instances are good to have. Also CI from case-insensitive

[thoughtpolice]

Are there currently instances for TypeReps and/or StaticPtrs? these will be needed for cloud haskell's Serializable class (also when's the name of that changing? =)

There are now instances for TypeRep and TyCon. StaticPtrs are looked up by a StaticKey which is just type StaticKey = Fingerprint which is also handled, so, basically, yes this should all be fine.

[Shimuuar]

I've started to add instances for all base data types.

What data format should newtype wrappers should use? Same format as underlying type or wrap it list?

[thoughtpolice]

What data format should newtype wrappers should use? Same format as underlying type or wrap it list?

I say wrap it, IMO. @dcoutts ?

[ghorn]

+1 wrap it to give newtypes more type safety when deserialising

I changed my mind. The point of newtypes is to have no runtime overhead by having identical runtime representation to the wrapped type.

[dcoutts]

I don't think newtype is special. The question about whether to use the standard constructor pattern or an more compact but non-upgradable representation comes down to the question: could the representation of this type ever possibly change? If the answer is no it cannot ever change then it's ok to use a more compact but non-upgradable representation.

[Shimuuar]

Here is list of missing instances for data types on which package depends:

array

• UArray
• Array

bytestring

• Lazy bytestring

text

• Lazy text

containers

• Forgotten and unloved Data.Tree.Tree

time

Basically all types. There're a lot of them

[ghorn]

Is the vector package part of the plan?

[Shimuuar]

It is. I've aded missing instances but yet to submit PR.

[axman6]

Are there currently instances for TypeReps and/or StaticPtrs? these will be needed for cloud haskell's Serializable class (also when's the name of that changing? =)

[phadej]

@ghorn, as @thoughtpolice mentioned, If Haskell Platform is the target, then: https://www.haskell.org/platform/contents.html and vector is there.

[thoughtpolice]

There are also now instances for all Data.Semigroup types in GHC 8.0+

[thoughtpolice]

We've implemented a lot of these; Vector is coming up soon now that Duncan merged the ST changes, and I believe the major outliers otherwise are array and some of the time types.

Thus, I'm closing this for now, and individual requests for core instances can be filed as new tickets.