Giter Site home page Giter Site logo

Comments (4)

edsko avatar edsko commented on August 16, 2024

Although I suppose maybe this is by design, so that if later constructors are added things don't break? If so, perhaps some convenience function to make it easier to define such instances manually might be helpful (if the programmer knows there will not be more constructors). The library provides instances for tuples, but only up to length 7 (I'm guessing the same function that I'm proposing here could also be useful to define those tuple instances).

from cborg.

dcoutts avatar dcoutts commented on August 16, 2024

This is by design. Actually I'm concerned that the single-constructor-single-field data types don't have a tag. The tags are not just for multiple constructors but to allow for migrations when you change the constructor in future.

from cborg.

dcoutts avatar dcoutts commented on August 16, 2024

The single-constructor-single-field special case should be eliminated. Those cases should use a tag too, otherwise there's no way to change the representation later and still be able to read old files.

from cborg.

bgamari avatar bgamari commented on August 16, 2024

Indeed the single-field case was eliminated in db52a11.

from cborg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.